From: James Sullivan <sullivan.james.f@gmail.com>
To: kvm@vger.kernel.org
Cc: gleb@kernel.org, pbonzini@redhat.com,
James Sullivan <sullivan.james.f@gmail.com>
Subject: [PATCH 2/9] Set irq->msi_redir_hint = 1 in kvm_set_msi_irq if RH=1
Date: Sat, 14 Mar 2015 18:00:17 -0600 [thread overview]
Message-ID: <1426377624-2046-3-git-send-email-sullivan.james.f@gmail.com> (raw)
In-Reply-To: <1426377624-2046-1-git-send-email-sullivan.james.f@gmail.com>
Signed-off-by: James Sullivan <sullivan.james.f@gmail.com>
---
arch/x86/kvm/irq_comm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
index f2887ea..7e0f469 100644
--- a/arch/x86/kvm/irq_comm.c
+++ b/arch/x86/kvm/irq_comm.c
@@ -116,9 +116,8 @@ static inline void kvm_set_msi_irq(struct kvm_kernel_irq_routing_entry *e,
irq->dest_mode = APIC_DEST_PHYSICAL;
irq->trig_mode = (1 << MSI_DATA_TRIGGER_SHIFT) & e->msi.data;
irq->delivery_mode = e->msi.data & 0x700;
- if (e->msi.address_lo & MSI_ADDR_REDIRECTION_LOWPRI)
- pr_warn_once(
- "kvm: MSIs may not be correctly delivered with RH set.\n");
+ irq->msi_redir_hint = ((e->msi.address_lo
+ & MSI_ADDR_REDIRECTION_LOWPRI) > 0);
irq->level = 1;
irq->shorthand = 0;
}
--
2.3.1
next prev parent reply other threads:[~2015-03-15 0:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 0:00 [PATCH RFC 0/9] Implement handling of RH=1 for MSI delivery in KVM James Sullivan
2015-03-15 0:00 ` [PATCH 1/9] Extended kvm_lapic_irq struct with 'bool redir_hint' for MSI delivery James Sullivan
2015-03-15 0:00 ` James Sullivan [this message]
2015-03-15 0:00 ` [PATCH 3/9] Set default value for msi_redir_hint=false in ioapic_service James Sullivan
2015-03-15 0:00 ` [PATCH 4/9] Set default value for msi_redir_hint=false in apic_send_ipi James Sullivan
2015-03-15 0:00 ` [PATCH 5/9] Set default value for msi_redir_hint=false in kvm_pv_kick_cpu_op James Sullivan
2015-03-15 0:00 ` [PATCH 6/9] Deliver to only low-prio cpu in kvm_irq_delivery_to_apic_fast when MSI RH=1 James Sullivan
2015-03-15 0:00 ` [PATCH 7/9] Prevent delivery to non-lowest priority vcpus in kvm_irq_delivery_to_apic James Sullivan
2015-03-15 0:00 ` [PATCH 8/9] Removed TODO in kvm_set_msi_irq James Sullivan
2015-03-15 0:00 ` [PATCH 9/9] Print value of msi_redir_hint in debug dump of irq in apic_send_ipi James Sullivan
2015-03-16 15:30 ` [PATCH RFC 0/9] Implement handling of RH=1 for MSI delivery in KVM Radim Krčmář
2015-03-17 1:11 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426377624-2046-3-git-send-email-sullivan.james.f@gmail.com \
--to=sullivan.james.f@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox