From: "Radim Krčmář" <rkrcmar@redhat.com>
To: James Sullivan <sullivan.james.f@gmail.com>
Cc: kvm@vger.kernel.org, gleb@kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH RFC 0/9] Implement handling of RH=1 for MSI delivery in KVM
Date: Mon, 16 Mar 2015 16:30:03 +0100 [thread overview]
Message-ID: <20150316153002.GA14281@potion.brq.redhat.com> (raw)
In-Reply-To: <1426377624-2046-1-git-send-email-sullivan.james.f@gmail.com>
2015-03-14 18:00-0600, James Sullivan:
> * DM=1, RH=0 : Logical destination mode without redirection. Interrupt
> is delivered to all LAPICs in the logical group
> specified by the IRQ's destination map and delivery
> mode.
Your previous patch changed this case to physical.
(Mention in the cover letter what unmerged patches you depend on.)
> Let me know your thoughts.
Please document changes in their commits; the information in cover
letter is virtually lost (git sucks at handling series).
If you feel like you would be repeating yourself, or have nothing to say
at all, it is a signal for rethinking the division.
The "logical change" of each patch doesn't need to be minimal -- we seek
the perfect balance between the number of patches, hunks in them, and
their complexity. I don't see a need for more than two patches here:
1) introduce and initialize msi_redir_hint [1-5,9/9]
2) use msi_redir_hint for lowest-priority delivery [6-8/9]
I think it would be better to rename the kvm_is_dm_lowest_prio() helper,
check for msi_redir_hint there, move it to a header, and use in
kvm_irq_delivery_to_apic_fast() too.
Thanks.
next prev parent reply other threads:[~2015-03-16 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 0:00 [PATCH RFC 0/9] Implement handling of RH=1 for MSI delivery in KVM James Sullivan
2015-03-15 0:00 ` [PATCH 1/9] Extended kvm_lapic_irq struct with 'bool redir_hint' for MSI delivery James Sullivan
2015-03-15 0:00 ` [PATCH 2/9] Set irq->msi_redir_hint = 1 in kvm_set_msi_irq if RH=1 James Sullivan
2015-03-15 0:00 ` [PATCH 3/9] Set default value for msi_redir_hint=false in ioapic_service James Sullivan
2015-03-15 0:00 ` [PATCH 4/9] Set default value for msi_redir_hint=false in apic_send_ipi James Sullivan
2015-03-15 0:00 ` [PATCH 5/9] Set default value for msi_redir_hint=false in kvm_pv_kick_cpu_op James Sullivan
2015-03-15 0:00 ` [PATCH 6/9] Deliver to only low-prio cpu in kvm_irq_delivery_to_apic_fast when MSI RH=1 James Sullivan
2015-03-15 0:00 ` [PATCH 7/9] Prevent delivery to non-lowest priority vcpus in kvm_irq_delivery_to_apic James Sullivan
2015-03-15 0:00 ` [PATCH 8/9] Removed TODO in kvm_set_msi_irq James Sullivan
2015-03-15 0:00 ` [PATCH 9/9] Print value of msi_redir_hint in debug dump of irq in apic_send_ipi James Sullivan
2015-03-16 15:30 ` Radim Krčmář [this message]
2015-03-17 1:11 ` [PATCH RFC 0/9] Implement handling of RH=1 for MSI delivery in KVM Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316153002.GA14281@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sullivan.james.f@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox