[kvm-unit-tests PATCH] lib: Add headers to generic library files

[kvm-unit-tests PATCH] lib: Add headers to generic library files

[Thomas Huth]

Many files in the lib folder do not have proper statements about
their license. Add such a header there so that it is clear under
which conditions the code can be used.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 lib/argv.c    | 7 +++++++
 lib/auxinfo.h | 4 ++++
 lib/errata.h  | 6 ++++++
 lib/printf.c  | 7 +++++++
 lib/setjmp.h  | 6 ++++++
 lib/stack.c   | 7 +++++++
 lib/stack.h   | 6 ++++++
 lib/string.c  | 7 +++++++
 lib/string.h  | 6 ++++++
 9 files changed, 56 insertions(+)

diff --git a/lib/argv.c b/lib/argv.c
index a37fc87..f2466d4 100644
--- a/lib/argv.c
+++ b/lib/argv.c
@@ -1,3 +1,10 @@
+/*
+ * Set up arguments for main() and prepare environment variables
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
+
 #include "libcflat.h"
 #include "auxinfo.h"
 
diff --git a/lib/auxinfo.h b/lib/auxinfo.h
index ef2376b..669ba5d 100644
--- a/lib/auxinfo.h
+++ b/lib/auxinfo.h
@@ -1,3 +1,7 @@
+/*
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
 #ifndef _AUXINFO_H_
 #define _AUXINFO_H_
 struct auxinfo {
diff --git a/lib/errata.h b/lib/errata.h
index 5e63f73..7b089c2 100644
--- a/lib/errata.h
+++ b/lib/errata.h
@@ -1,3 +1,9 @@
+/*
+ * errata functions
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
 #ifndef _ERRATA_H_
 #define _ERRATA_H_
 
diff --git a/lib/printf.c b/lib/printf.c
index 2aec59a..063a1ed 100644
--- a/lib/printf.c
+++ b/lib/printf.c
@@ -1,3 +1,10 @@
+/*
+ * libc printf and friends
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
+
 #include "libcflat.h"
 
 #define BUFSZ 2000
diff --git a/lib/setjmp.h b/lib/setjmp.h
index 334f466..2c56b4c 100644
--- a/lib/setjmp.h
+++ b/lib/setjmp.h
@@ -1,3 +1,9 @@
+/*
+ * setjmp/longjmp prototypes
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
 #ifndef LIBCFLAT_SETJMP_H
 #define LIBCFLAT_SETJMP_H 1
 
diff --git a/lib/stack.c b/lib/stack.c
index b0a0295..bdb23fd 100644
--- a/lib/stack.c
+++ b/lib/stack.c
@@ -1,3 +1,10 @@
+/*
+ * stack related functions
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
+
 #include <libcflat.h>
 #include <stack.h>
 
diff --git a/lib/stack.h b/lib/stack.h
index cfc66f4..10fc2f7 100644
--- a/lib/stack.h
+++ b/lib/stack.h
@@ -1,3 +1,9 @@
+/*
+ * Header for stack related functions
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
 #ifndef _STACK_H_
 #define _STACK_H_
 
diff --git a/lib/string.c b/lib/string.c
index 833f22b..776fa0d 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -1,3 +1,10 @@
+/*
+ * libc string functions
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
+
 #include "libcflat.h"
 
 unsigned long strlen(const char *buf)
diff --git a/lib/string.h b/lib/string.h
index 2391013..493d51b 100644
--- a/lib/string.h
+++ b/lib/string.h
@@ -1,3 +1,9 @@
+/*
+ * Header for libc string functions
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Library General Public License version 2.
+ */
 #ifndef __STRING_H
 #define __STRING_H
 
-- 
1.8.3.1

Re: [kvm-unit-tests PATCH] lib: Add headers to generic library files

[Andrew Jones]

On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote:
> Many files in the lib folder do not have proper statements about
> their license. Add such a header there so that it is clear under
> which conditions the code can be used.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  lib/argv.c    | 7 +++++++
>  lib/auxinfo.h | 4 ++++
>  lib/errata.h  | 6 ++++++
>  lib/printf.c  | 7 +++++++
>  lib/setjmp.h  | 6 ++++++
>  lib/stack.c   | 7 +++++++
>  lib/stack.h   | 6 ++++++
>  lib/string.c  | 7 +++++++
>  lib/string.h  | 6 ++++++
>  9 files changed, 56 insertions(+)
> 
> diff --git a/lib/argv.c b/lib/argv.c
> index a37fc87..f2466d4 100644
> --- a/lib/argv.c
> +++ b/lib/argv.c
> @@ -1,3 +1,10 @@
> +/*
> + * Set up arguments for main() and prepare environment variables
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
> +
>  #include "libcflat.h"
>  #include "auxinfo.h"
>  
> diff --git a/lib/auxinfo.h b/lib/auxinfo.h
> index ef2376b..669ba5d 100644
> --- a/lib/auxinfo.h
> +++ b/lib/auxinfo.h
> @@ -1,3 +1,7 @@
> +/*
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
>  #ifndef _AUXINFO_H_
>  #define _AUXINFO_H_
>  struct auxinfo {
> diff --git a/lib/errata.h b/lib/errata.h
> index 5e63f73..7b089c2 100644
> --- a/lib/errata.h
> +++ b/lib/errata.h
> @@ -1,3 +1,9 @@
> +/*
> + * errata functions
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
>  #ifndef _ERRATA_H_
>  #define _ERRATA_H_
>  
> diff --git a/lib/printf.c b/lib/printf.c
> index 2aec59a..063a1ed 100644
> --- a/lib/printf.c
> +++ b/lib/printf.c
> @@ -1,3 +1,10 @@
> +/*
> + * libc printf and friends
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
> +
>  #include "libcflat.h"
>  
>  #define BUFSZ 2000
> diff --git a/lib/setjmp.h b/lib/setjmp.h
> index 334f466..2c56b4c 100644
> --- a/lib/setjmp.h
> +++ b/lib/setjmp.h
> @@ -1,3 +1,9 @@
> +/*
> + * setjmp/longjmp prototypes
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
>  #ifndef LIBCFLAT_SETJMP_H
>  #define LIBCFLAT_SETJMP_H 1
>  
> diff --git a/lib/stack.c b/lib/stack.c
> index b0a0295..bdb23fd 100644
> --- a/lib/stack.c
> +++ b/lib/stack.c
> @@ -1,3 +1,10 @@
> +/*
> + * stack related functions
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
> +
>  #include <libcflat.h>
>  #include <stack.h>
>  
> diff --git a/lib/stack.h b/lib/stack.h
> index cfc66f4..10fc2f7 100644
> --- a/lib/stack.h
> +++ b/lib/stack.h
> @@ -1,3 +1,9 @@
> +/*
> + * Header for stack related functions
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
>  #ifndef _STACK_H_
>  #define _STACK_H_
>  
> diff --git a/lib/string.c b/lib/string.c
> index 833f22b..776fa0d 100644
> --- a/lib/string.c
> +++ b/lib/string.c
> @@ -1,3 +1,10 @@
> +/*
> + * libc string functions
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
> +
>  #include "libcflat.h"
>  
>  unsigned long strlen(const char *buf)
> diff --git a/lib/string.h b/lib/string.h
> index 2391013..493d51b 100644
> --- a/lib/string.h
> +++ b/lib/string.h
> @@ -1,3 +1,9 @@
> +/*
> + * Header for libc string functions
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU Library General Public License version 2.
> + */
>  #ifndef __STRING_H
>  #define __STRING_H
>  
> -- 
> 1.8.3.1
>

Reviewed-by: Andrew Jones <drjones@redhat.com>

Thanks,
drew 

Re: [kvm-unit-tests PATCH] lib: Add headers to generic library files

[Thomas Huth]

On 07.04.2017 15:49, Andrew Jones wrote:
> On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote:
>> Many files in the lib folder do not have proper statements about
>> their license. Add such a header there so that it is clear under
>> which conditions the code can be used.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  lib/argv.c    | 7 +++++++
>>  lib/auxinfo.h | 4 ++++
>>  lib/errata.h  | 6 ++++++
>>  lib/printf.c  | 7 +++++++
>>  lib/setjmp.h  | 6 ++++++
>>  lib/stack.c   | 7 +++++++
>>  lib/stack.h   | 6 ++++++
>>  lib/string.c  | 7 +++++++
>>  lib/string.h  | 6 ++++++
>>  9 files changed, 56 insertions(+)
>>
>> diff --git a/lib/argv.c b/lib/argv.c
>> index a37fc87..f2466d4 100644
>> --- a/lib/argv.c
>> +++ b/lib/argv.c
>> @@ -1,3 +1,10 @@
>> +/*
>> + * Set up arguments for main() and prepare environment variables
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>> +
>>  #include "libcflat.h"
>>  #include "auxinfo.h"
>>  
>> diff --git a/lib/auxinfo.h b/lib/auxinfo.h
>> index ef2376b..669ba5d 100644
>> --- a/lib/auxinfo.h
>> +++ b/lib/auxinfo.h
>> @@ -1,3 +1,7 @@
>> +/*
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>>  #ifndef _AUXINFO_H_
>>  #define _AUXINFO_H_
>>  struct auxinfo {
>> diff --git a/lib/errata.h b/lib/errata.h
>> index 5e63f73..7b089c2 100644
>> --- a/lib/errata.h
>> +++ b/lib/errata.h
>> @@ -1,3 +1,9 @@
>> +/*
>> + * errata functions
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>>  #ifndef _ERRATA_H_
>>  #define _ERRATA_H_
>>  
>> diff --git a/lib/printf.c b/lib/printf.c
>> index 2aec59a..063a1ed 100644
>> --- a/lib/printf.c
>> +++ b/lib/printf.c
>> @@ -1,3 +1,10 @@
>> +/*
>> + * libc printf and friends
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>> +
>>  #include "libcflat.h"
>>  
>>  #define BUFSZ 2000
>> diff --git a/lib/setjmp.h b/lib/setjmp.h
>> index 334f466..2c56b4c 100644
>> --- a/lib/setjmp.h
>> +++ b/lib/setjmp.h
>> @@ -1,3 +1,9 @@
>> +/*
>> + * setjmp/longjmp prototypes
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>>  #ifndef LIBCFLAT_SETJMP_H
>>  #define LIBCFLAT_SETJMP_H 1
>>  
>> diff --git a/lib/stack.c b/lib/stack.c
>> index b0a0295..bdb23fd 100644
>> --- a/lib/stack.c
>> +++ b/lib/stack.c
>> @@ -1,3 +1,10 @@
>> +/*
>> + * stack related functions
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>> +
>>  #include <libcflat.h>
>>  #include <stack.h>
>>  
>> diff --git a/lib/stack.h b/lib/stack.h
>> index cfc66f4..10fc2f7 100644
>> --- a/lib/stack.h
>> +++ b/lib/stack.h
>> @@ -1,3 +1,9 @@
>> +/*
>> + * Header for stack related functions
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>>  #ifndef _STACK_H_
>>  #define _STACK_H_
>>  
>> diff --git a/lib/string.c b/lib/string.c
>> index 833f22b..776fa0d 100644
>> --- a/lib/string.c
>> +++ b/lib/string.c
>> @@ -1,3 +1,10 @@
>> +/*
>> + * libc string functions
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>> +
>>  #include "libcflat.h"
>>  
>>  unsigned long strlen(const char *buf)
>> diff --git a/lib/string.h b/lib/string.h
>> index 2391013..493d51b 100644
>> --- a/lib/string.h
>> +++ b/lib/string.h
>> @@ -1,3 +1,9 @@
>> +/*
>> + * Header for libc string functions
>> + *
>> + * This code is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU Library General Public License version 2.
>> + */
>>  #ifndef __STRING_H
>>  #define __STRING_H
>>  
>> -- 
>> 1.8.3.1
>>
> 
> Reviewed-by: Andrew Jones <drjones@redhat.com>

*ping*

Paolo, Radim, could you pick this up please if it sounds OK for you?

 Thanks,
  Thomas

Re: [kvm-unit-tests PATCH] lib: Add headers to generic library files

[Radim Krčmář]

2017-04-25 09:11+0200, Thomas Huth:
> On 07.04.2017 15:49, Andrew Jones wrote:
>> On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote:
>>> Many files in the lib folder do not have proper statements about
>>> their license. Add such a header there so that it is clear under
>>> which conditions the code can be used.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>> diff --git a/lib/argv.c b/lib/argv.c
>>> @@ -1,3 +1,10 @@
>>> +/*
>>> + * Set up arguments for main() and prepare environment variables
>>> + *
>>> + * This code is free software; you can redistribute it and/or modify it
>>> + * under the terms of the GNU Library General Public License version 2.
>>> + */
>>> +
>>>  #include "libcflat.h"
>>>  #include "auxinfo.h"
>>>  
>> 
>> Reviewed-by: Andrew Jones <drjones@redhat.com>
> 
> *ping*

(Sorry, I'll need to double-check all unit test patches from that time.)

> Paolo, Radim, could you pick this up please if it sounds OK for you?

It does, the licensing follows COPYRIGHT and I assume that we can't
change the license without a lot of legal hassle.

Took me a while to realize what isn't clear: libcflat.h is GPL 2 and
being explicit with the border between GPL 2 and LGPL 2 sounds good for
re-usability of the code.  (I assume that the whole kvm-unit-tests is
effectively GPL 2, but parts of it are more benevolent.)

Applied, thanks.

Re: [kvm-unit-tests PATCH] lib: Add headers to generic library files

[Thomas Huth]

On 25.04.2017 17:32, Radim Krčmář wrote:
> 2017-04-25 09:11+0200, Thomas Huth:
>> On 07.04.2017 15:49, Andrew Jones wrote:
>>> On Fri, Apr 07, 2017 at 03:16:57PM +0200, Thomas Huth wrote:
>>>> Many files in the lib folder do not have proper statements about
>>>> their license. Add such a header there so that it is clear under
>>>> which conditions the code can be used.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>> diff --git a/lib/argv.c b/lib/argv.c
>>>> @@ -1,3 +1,10 @@
>>>> +/*
>>>> + * Set up arguments for main() and prepare environment variables
>>>> + *
>>>> + * This code is free software; you can redistribute it and/or modify it
>>>> + * under the terms of the GNU Library General Public License version 2.
>>>> + */
>>>> +
>>>>  #include "libcflat.h"
>>>>  #include "auxinfo.h"
>>>>  
>>>
>>> Reviewed-by: Andrew Jones <drjones@redhat.com>
>>
>> *ping*
> 
> (Sorry, I'll need to double-check all unit test patches from that time.)
> 
>> Paolo, Radim, could you pick this up please if it sounds OK for you?
> 
> It does, the licensing follows COPYRIGHT and I assume that we can't
> change the license without a lot of legal hassle.
> 
> Took me a while to realize what isn't clear: libcflat.h is GPL 2 and
> being explicit with the border between GPL 2 and LGPL 2 sounds good for
> re-usability of the code.  (I assume that the whole kvm-unit-tests is
> effectively GPL 2, but parts of it are more benevolent.)

I think we should update the COPYRIGHT file with this information -
saying that the whole kvm-unit-tests is under GPL 2 nowadays, but single
files might be LGPL 2 (or other compatible licenses) instead...

 Thomas