* [PATCH] Fix coalesced interrupt reporting in IOAPIC
@ 2009-09-03 9:10 Gleb Natapov
2009-09-03 17:31 ` Marcelo Tosatti
0 siblings, 1 reply; 2+ messages in thread
From: Gleb Natapov @ 2009-09-03 9:10 UTC (permalink / raw)
To: mtosatti; +Cc: kvm
This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073
Signed-off-by: Gleb Natapov <gleb@redhat.com>
diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
index e9de458..38a2d20 100644
--- a/virt/kvm/ioapic.c
+++ b/virt/kvm/ioapic.c
@@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
if ((edge && old_irr != ioapic->irr) ||
(!edge && !entry.fields.remote_irr))
ret = ioapic_service(ioapic, irq);
+ else
+ ret = 0; /* report coalesced interrupt */
}
trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
}
--
Gleb.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix coalesced interrupt reporting in IOAPIC
2009-09-03 9:10 [PATCH] Fix coalesced interrupt reporting in IOAPIC Gleb Natapov
@ 2009-09-03 17:31 ` Marcelo Tosatti
0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2009-09-03 17:31 UTC (permalink / raw)
To: Gleb Natapov; +Cc: kvm
On Thu, Sep 03, 2009 at 12:10:34PM +0300, Gleb Natapov wrote:
> This bug was introduced by b4a2f5e723e4f7df46731106faf9e2405673c073
>
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> diff --git a/virt/kvm/ioapic.c b/virt/kvm/ioapic.c
> index e9de458..38a2d20 100644
> --- a/virt/kvm/ioapic.c
> +++ b/virt/kvm/ioapic.c
> @@ -194,6 +194,8 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int level)
> if ((edge && old_irr != ioapic->irr) ||
> (!edge && !entry.fields.remote_irr))
> ret = ioapic_service(ioapic, irq);
> + else
> + ret = 0; /* report coalesced interrupt */
> }
> trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
> }
> --
> Gleb.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-03 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-03 9:10 [PATCH] Fix coalesced interrupt reporting in IOAPIC Gleb Natapov
2009-09-03 17:31 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox