* [PATCH] pci-assign: Fix MSI-X MMIO page registration
@ 2011-10-12 17:02 Jan Kiszka
2011-10-12 17:14 ` Alex Williamson
2011-10-19 15:53 ` Marcelo Tosatti
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2011-10-12 17:02 UTC (permalink / raw)
To: Avi Kivity, Marcelo Tosatti; +Cc: kvm, Alex Williamson
The MSI-X page must start below the address that comes after the end of
a region. Otherwise we risk to register it twice. This bug existed since
day #1 of the MSI-X support and was now reveal by
memory.c:1201: memory_region_add_subregion_common: Assertion `!subregion->parent' failed.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/device-assignment.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 054b059..11efd16 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -246,7 +246,7 @@ static void assigned_dev_iomem_setup(PCIDevice *pci_dev, int region_num,
/* deal with MSI-X MMIO page */
if (real_region->base_addr <= r_dev->msix_table_addr &&
- real_region->base_addr + real_region->size >=
+ real_region->base_addr + real_region->size >
r_dev->msix_table_addr) {
int offset = r_dev->msix_table_addr - real_region->base_addr;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pci-assign: Fix MSI-X MMIO page registration
2011-10-12 17:02 [PATCH] pci-assign: Fix MSI-X MMIO page registration Jan Kiszka
@ 2011-10-12 17:14 ` Alex Williamson
2011-10-19 15:53 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2011-10-12 17:14 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Avi Kivity, Marcelo Tosatti, kvm
On Wed, 2011-10-12 at 19:02 +0200, Jan Kiszka wrote:
> The MSI-X page must start below the address that comes after the end of
> a region. Otherwise we risk to register it twice. This bug existed since
> day #1 of the MSI-X support and was now reveal by
>
> memory.c:1201: memory_region_add_subregion_common: Assertion `!subregion->parent' failed.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/device-assignment.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/device-assignment.c b/hw/device-assignment.c
> index 054b059..11efd16 100644
> --- a/hw/device-assignment.c
> +++ b/hw/device-assignment.c
> @@ -246,7 +246,7 @@ static void assigned_dev_iomem_setup(PCIDevice *pci_dev, int region_num,
>
> /* deal with MSI-X MMIO page */
> if (real_region->base_addr <= r_dev->msix_table_addr &&
> - real_region->base_addr + real_region->size >=
> + real_region->base_addr + real_region->size >
> r_dev->msix_table_addr) {
> int offset = r_dev->msix_table_addr - real_region->base_addr;
>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pci-assign: Fix MSI-X MMIO page registration
2011-10-12 17:02 [PATCH] pci-assign: Fix MSI-X MMIO page registration Jan Kiszka
2011-10-12 17:14 ` Alex Williamson
@ 2011-10-19 15:53 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2011-10-19 15:53 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Avi Kivity, kvm, Alex Williamson
On Wed, Oct 12, 2011 at 07:02:37PM +0200, Jan Kiszka wrote:
> The MSI-X page must start below the address that comes after the end of
> a region. Otherwise we risk to register it twice. This bug existed since
> day #1 of the MSI-X support and was now reveal by
>
> memory.c:1201: memory_region_add_subregion_common: Assertion `!subregion->parent' failed.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/device-assignment.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-19 15:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-12 17:02 [PATCH] pci-assign: Fix MSI-X MMIO page registration Jan Kiszka
2011-10-12 17:14 ` Alex Williamson
2011-10-19 15:53 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox