[PATCH v2] KVM: PPC: Rework wqp conditional code

[PATCH v2] KVM: PPC: Rework wqp conditional code

[Alexander Graf]

On PowerPC, we sometimes use a waitqueue per core, not per thread,
so we can't always use the vcpu internal waitqueue.

This code has been generalized by Christoffer Dall recently, but
unfortunately broke compilation for PowerPC. At the time the helper
function is defined, struct kvm_vcpu is not declared yet, so we can't
dereference it.

This patch moves all logic into the generic inline function, at which
time we have all information necessary.

Signed-off-by: Alexander Graf <agraf@suse.de>

---

v1 -> v2:

  - fix typo
---
 arch/powerpc/include/asm/kvm_host.h |    6 +-----
 include/linux/kvm_host.h            |    6 ++++--
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h
index a91d6fd..42a527e 100644
--- a/arch/powerpc/include/asm/kvm_host.h
+++ b/arch/powerpc/include/asm/kvm_host.h
@@ -538,10 +538,6 @@ struct kvm_vcpu_arch {
 #define KVM_MMIO_REG_QPR	0x0040
 #define KVM_MMIO_REG_FQPR	0x0060
 
-#define __KVM_HAVE_ARCH_VCPU_GET_WQ 1
-static inline wait_queue_head *kvm_arch_vcpu_wq(struct kvm_vcpu *vcpu)
-{
-	return vcpu->arch.wqp;
-}
+#define __KVM_HAVE_ARCH_WQP
 
 #endif /* __POWERPC_KVM_HOST_H__ */
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 50d4b4a..b18ae78 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -523,12 +523,14 @@ static inline void kvm_arch_free_vm(struct kvm *kvm)
 }
 #endif
 
-#ifndef __KVM_HAVE_ARCH_VCPU_GET_WQ
 static inline wait_queue_head_t *kvm_arch_vcpu_wq(struct kvm_vcpu *vcpu)
 {
+#ifdef __KVM_HAVE_ARCH_WQP
+	return vcpu->arch.wqp;
+#else
 	return &vcpu->wq;
-}
 #endif
+}
 
 int kvm_arch_init_vm(struct kvm *kvm, unsigned long type);
 void kvm_arch_destroy_vm(struct kvm *kvm);
-- 
1.6.0.2

Re: [PATCH v2] KVM: PPC: Rework wqp conditional code

[Marcelo Tosatti]

On Tue, Mar 13, 2012 at 10:35:01PM +0100, Alexander Graf wrote:
> On PowerPC, we sometimes use a waitqueue per core, not per thread,
> so we can't always use the vcpu internal waitqueue.
> 
> This code has been generalized by Christoffer Dall recently, but
> unfortunately broke compilation for PowerPC. At the time the helper
> function is defined, struct kvm_vcpu is not declared yet, so we can't
> dereference it.
> 
> This patch moves all logic into the generic inline function, at which
> time we have all information necessary.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Applied, thanks.