* [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
@ 2019-03-20 6:47 Wang Hai
2019-03-20 0:39 ` Alexey Kardashevskiy
2019-04-03 18:52 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Wang Hai @ 2019-03-20 6:47 UTC (permalink / raw)
To: alex.williamson; +Cc: kvm, linux-kernel
Fixes the following sparse warning:
drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
Signed-off-by: Wang Hai <wanghai26@huawei.com>
---
drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
index 8dbb270..6b64e45 100644
--- a/drivers/vfio/vfio_iommu_spapr_tce.c
+++ b/drivers/vfio/vfio_iommu_spapr_tce.c
@@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,
mutex_unlock(&container->lock);
}
-const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
+static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
.name = "iommu-vfio-powerpc",
.owner = THIS_MODULE,
.open = tce_iommu_open,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
2019-03-20 6:47 [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static Wang Hai
@ 2019-03-20 0:39 ` Alexey Kardashevskiy
2019-04-03 18:52 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Kardashevskiy @ 2019-03-20 0:39 UTC (permalink / raw)
To: Wang Hai, alex.williamson; +Cc: kvm, linux-kernel
On 20/03/2019 17:47, Wang Hai wrote:
> Fixes the following sparse warning:
>
> drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
> symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
>
> Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
> Signed-off-by: Wang Hai <wanghai26@huawei.com>
I am curious - what exactly did you do to get this warning?
Anyway,
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 8dbb270..6b64e45 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,
> mutex_unlock(&container->lock);
> }
>
> -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> .name = "iommu-vfio-powerpc",
> .owner = THIS_MODULE,
> .open = tce_iommu_open,
>
--
Alexey
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static
2019-03-20 6:47 [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static Wang Hai
2019-03-20 0:39 ` Alexey Kardashevskiy
@ 2019-04-03 18:52 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2019-04-03 18:52 UTC (permalink / raw)
To: Wang Hai; +Cc: kvm, linux-kernel
On Wed, 20 Mar 2019 02:47:23 -0400
Wang Hai <wanghai26@huawei.com> wrote:
> Fixes the following sparse warning:
>
> drivers/vfio/vfio_iommu_spapr_tce.c:1401:36: warning:
> symbol 'tce_iommu_driver_ops' was not declared. Should it be static?
>
> Fixes: 5ffd229c0273 ("powerpc/vfio: Implement IOMMU driver for VFIO")
> Signed-off-by: Wang Hai <wanghai26@huawei.com>
> ---
Applied to vfio for-linus branch for v5.1 with Alexey's R-b. Thanks!
Alex
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 8dbb270..6b64e45 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -1398,7 +1398,7 @@ static void tce_iommu_detach_group(void *iommu_data,
> mutex_unlock(&container->lock);
> }
>
> -const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> +static const struct vfio_iommu_driver_ops tce_iommu_driver_ops = {
> .name = "iommu-vfio-powerpc",
> .owner = THIS_MODULE,
> .open = tce_iommu_open,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-03 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 6:47 [PATCH] vfio/spapr_tce: Make symbol 'tce_iommu_driver_ops' static Wang Hai
2019-03-20 0:39 ` Alexey Kardashevskiy
2019-04-03 18:52 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox