From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
kvm@vger.kernel.org, "Wanpeng Li" <wanpengli@tencent.com>
Subject: Re: [PATCH 6/7] KVM: lapic: Clean up the code for handling of a pre-expired hv_timer
Date: Tue, 16 Apr 2019 10:27:11 -0700 [thread overview]
Message-ID: <20190416172711.GB21674@linux.intel.com> (raw)
In-Reply-To: <EBF51FC6-416E-4D44-87AB-5DFE8D9430B3@oracle.com>
On Tue, Apr 16, 2019 at 07:48:42PM +0300, Liran Alon wrote:
Yes I understood that already.
> I don’t think it contradicts the fact that the checks I mentioned above
> should be moved out of start_hv_timer().
Ah, I misread your comment. I think. My head is spinning trying to
work through this code.
> > I think Paolo's suggestion of moving the logic up into restart_apic_timer()
> > is the way to go as it reduces the multiplexing down on start_hv_timer()'s
> > return value.
> >
>
> Yes I agree. I plan to do so.
And because I misread your comment, I already created this patch. I'll
send it out shortly.
next prev parent reply other threads:[~2019-04-16 17:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 20:18 [PATCH 0/7] KVM: lapic: Fix a variety of timer adv issues Sean Christopherson
2019-04-12 20:18 ` [PATCH 1/7] KVM: lapic: Hard cap the auto-calculated timer advancement Sean Christopherson
2019-04-14 10:22 ` Liran Alon
2019-04-12 20:18 ` [PATCH 2/7] KVM: lapic: Delay 1ns at a time when waiting for timer to "expire" Sean Christopherson
2019-04-14 11:25 ` Liran Alon
2019-04-15 16:11 ` Sean Christopherson
2019-04-15 17:06 ` Liran Alon
2019-04-16 11:02 ` Paolo Bonzini
2019-04-16 11:04 ` Liran Alon
2019-04-16 11:09 ` Paolo Bonzini
2019-04-12 20:18 ` [PATCH 3/7] KVM: lapic: Track lapic timer advance per vCPU Sean Christopherson
2019-04-14 11:29 ` Liran Alon
2019-04-12 20:18 ` [PATCH 4/7] KVM: lapic: Allow user to override auto-tuning of timer advancement Sean Christopherson
2019-04-14 11:35 ` Liran Alon
2019-04-15 16:23 ` Sean Christopherson
2019-04-15 17:10 ` Liran Alon
2019-04-12 20:18 ` [PATCH 5/7] KVM: lapic: Busy wait for timer to expire when using hv_timer Sean Christopherson
2019-04-14 11:47 ` Liran Alon
2019-04-12 20:18 ` [PATCH 6/7] KVM: lapic: Clean up the code for handling of a pre-expired hv_timer Sean Christopherson
2019-04-14 12:15 ` Liran Alon
2019-04-15 16:32 ` Sean Christopherson
2019-04-15 17:25 ` Liran Alon
2019-04-16 16:39 ` Sean Christopherson
2019-04-16 16:48 ` Liran Alon
2019-04-16 17:27 ` Sean Christopherson [this message]
2019-04-16 17:27 ` Liran Alon
2019-04-16 11:14 ` Paolo Bonzini
2019-04-12 20:18 ` [PATCH 7/7] KVM: VMX: Skip delta_tsc shift-and-divide if the dividend is zero Sean Christopherson
2019-04-14 12:21 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416172711.GB21674@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox