* [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
@ 2020-07-14 4:19 Sean Christopherson
2020-07-14 4:37 ` Nadav Amit
2020-07-15 14:31 ` Claudio Imbrenda
0 siblings, 2 replies; 3+ messages in thread
From: Sean Christopherson @ 2020-07-14 4:19 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm, Sean Christopherson
Replace a '%' with a '$' to encode a literal in when initializing CR4.
This fixes the build on i386 as gcc complains about a non-existent
register.
x86/cstart.S: Assembler messages:
x86/cstart.S:128: Error: bad register name `%(1<<4)'
Makefile:101: recipe for target 'x86/cstart.o' failed
Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero")
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
---
x86/cstart.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/cstart.S b/x86/cstart.S
index e63e4e2..c0efc5f 100644
--- a/x86/cstart.S
+++ b/x86/cstart.S
@@ -125,7 +125,7 @@ start:
jmpl $8, $start32
prepare_32:
- mov %(1 << 4), %eax // pse
+ mov $(1 << 4), %eax // pse
mov %eax, %cr4
mov $pt, %eax
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
2020-07-14 4:19 [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Sean Christopherson
@ 2020-07-14 4:37 ` Nadav Amit
2020-07-15 14:31 ` Claudio Imbrenda
1 sibling, 0 replies; 3+ messages in thread
From: Nadav Amit @ 2020-07-14 4:37 UTC (permalink / raw)
To: Sean Christopherson; +Cc: Paolo Bonzini, kvm
> On Jul 13, 2020, at 9:19 PM, Sean Christopherson <sean.j.christopherson@intel.com> wrote:
>
> Replace a '%' with a '$' to encode a literal in when initializing CR4.
> This fixes the build on i386 as gcc complains about a non-existent
> register.
Reviewed-by: Nadav Amit <namit@vmware.com>
( I should have noticed it before )
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
2020-07-14 4:19 [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Sean Christopherson
2020-07-14 4:37 ` Nadav Amit
@ 2020-07-15 14:31 ` Claudio Imbrenda
1 sibling, 0 replies; 3+ messages in thread
From: Claudio Imbrenda @ 2020-07-15 14:31 UTC (permalink / raw)
To: Sean Christopherson; +Cc: Paolo Bonzini, kvm
On Mon, 13 Jul 2020 21:19:05 -0700
Sean Christopherson <sean.j.christopherson@intel.com> wrote:
> Replace a '%' with a '$' to encode a literal in when initializing CR4.
> This fixes the build on i386 as gcc complains about a non-existent
> register.
>
> x86/cstart.S: Assembler messages:
> x86/cstart.S:128: Error: bad register name `%(1<<4)'
> Makefile:101: recipe for target 'x86/cstart.o' failed
>
> Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero")
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> x86/cstart.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/cstart.S b/x86/cstart.S
> index e63e4e2..c0efc5f 100644
> --- a/x86/cstart.S
> +++ b/x86/cstart.S
> @@ -125,7 +125,7 @@ start:
> jmpl $8, $start32
>
> prepare_32:
> - mov %(1 << 4), %eax // pse
> + mov $(1 << 4), %eax // pse
> mov %eax, %cr4
>
> mov $pt, %eax
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-15 14:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-14 4:19 [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Sean Christopherson
2020-07-14 4:37 ` Nadav Amit
2020-07-15 14:31 ` Claudio Imbrenda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox