* [PATCH] vfio-pci/zdev: Remove repeated verbose license text
@ 2021-08-22 4:35 Cai Huoqing
2021-08-23 16:02 ` Matthew Rosato
2021-08-23 16:20 ` Alex Williamson
0 siblings, 2 replies; 4+ messages in thread
From: Cai Huoqing @ 2021-08-22 4:35 UTC (permalink / raw)
To: mjrosato, farman, alex.williamson, cohuck; +Cc: linux-s390, kvm, Cai Huoqing
remove it because SPDX-License-Identifier is already used
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/vfio/pci/vfio_pci_zdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
index 7b011b62c766..dfd8d826223d 100644
--- a/drivers/vfio/pci/vfio_pci_zdev.c
+++ b/drivers/vfio/pci/vfio_pci_zdev.c
@@ -5,11 +5,6 @@
* Copyright (C) IBM Corp. 2020. All rights reserved.
* Author(s): Pierre Morel <pmorel@linux.ibm.com>
* Matthew Rosato <mjrosato@linux.ibm.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
*/
#include <linux/io.h>
#include <linux/pci.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] vfio-pci/zdev: Remove repeated verbose license text
2021-08-22 4:35 [PATCH] vfio-pci/zdev: Remove repeated verbose license text Cai Huoqing
@ 2021-08-23 16:02 ` Matthew Rosato
2021-08-23 16:20 ` Alex Williamson
1 sibling, 0 replies; 4+ messages in thread
From: Matthew Rosato @ 2021-08-23 16:02 UTC (permalink / raw)
To: Cai Huoqing, farman, alex.williamson, cohuck; +Cc: linux-s390, kvm
On 8/22/21 12:35 AM, Cai Huoqing wrote:
> remove it because SPDX-License-Identifier is already used
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
> drivers/vfio/pci/vfio_pci_zdev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
> index 7b011b62c766..dfd8d826223d 100644
> --- a/drivers/vfio/pci/vfio_pci_zdev.c
> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
> @@ -5,11 +5,6 @@
> * Copyright (C) IBM Corp. 2020. All rights reserved.
> * Author(s): Pierre Morel <pmorel@linux.ibm.com>
> * Matthew Rosato <mjrosato@linux.ibm.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> */
> #include <linux/io.h>
> #include <linux/pci.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vfio-pci/zdev: Remove repeated verbose license text
2021-08-22 4:35 [PATCH] vfio-pci/zdev: Remove repeated verbose license text Cai Huoqing
2021-08-23 16:02 ` Matthew Rosato
@ 2021-08-23 16:20 ` Alex Williamson
2021-08-23 16:26 ` Matthew Rosato
1 sibling, 1 reply; 4+ messages in thread
From: Alex Williamson @ 2021-08-23 16:20 UTC (permalink / raw)
To: Cai Huoqing; +Cc: mjrosato, farman, cohuck, linux-s390, kvm
On Sun, 22 Aug 2021 12:35:00 +0800
Cai Huoqing <caihuoqing@baidu.com> wrote:
> remove it because SPDX-License-Identifier is already used
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/vfio/pci/vfio_pci_zdev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
> index 7b011b62c766..dfd8d826223d 100644
> --- a/drivers/vfio/pci/vfio_pci_zdev.c
> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
> @@ -5,11 +5,6 @@
> * Copyright (C) IBM Corp. 2020. All rights reserved.
> * Author(s): Pierre Morel <pmorel@linux.ibm.com>
> * Matthew Rosato <mjrosato@linux.ibm.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> */
> #include <linux/io.h>
> #include <linux/pci.h>
The SPDX license for this file is actually GPL-2.0+ but the text here
matches the more restrictive GPL-2.0. I'm not a lawyer, but I'd expect
the more restrictive license holds, so removing this text might
actually change the license. Should this also correct the SPDX
license? Perhaps we need clarification from the authors. Thanks,
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vfio-pci/zdev: Remove repeated verbose license text
2021-08-23 16:20 ` Alex Williamson
@ 2021-08-23 16:26 ` Matthew Rosato
0 siblings, 0 replies; 4+ messages in thread
From: Matthew Rosato @ 2021-08-23 16:26 UTC (permalink / raw)
To: Alex Williamson, Cai Huoqing; +Cc: farman, cohuck, linux-s390, kvm
On 8/23/21 12:20 PM, Alex Williamson wrote:
> On Sun, 22 Aug 2021 12:35:00 +0800
> Cai Huoqing <caihuoqing@baidu.com> wrote:
>
>> remove it because SPDX-License-Identifier is already used
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
>> ---
>> drivers/vfio/pci/vfio_pci_zdev.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/vfio/pci/vfio_pci_zdev.c b/drivers/vfio/pci/vfio_pci_zdev.c
>> index 7b011b62c766..dfd8d826223d 100644
>> --- a/drivers/vfio/pci/vfio_pci_zdev.c
>> +++ b/drivers/vfio/pci/vfio_pci_zdev.c
>> @@ -5,11 +5,6 @@
>> * Copyright (C) IBM Corp. 2020. All rights reserved.
>> * Author(s): Pierre Morel <pmorel@linux.ibm.com>
>> * Matthew Rosato <mjrosato@linux.ibm.com>
>> - *
>> - * This program is free software; you can redistribute it and/or modify
>> - * it under the terms of the GNU General Public License version 2 as
>> - * published by the Free Software Foundation.
>> - *
>> */
>> #include <linux/io.h>
>> #include <linux/pci.h>
>
> The SPDX license for this file is actually GPL-2.0+ but the text here
> matches the more restrictive GPL-2.0. I'm not a lawyer, but I'd expect
> the more restrictive license holds, so removing this text might
> actually change the license. Should this also correct the SPDX
> license? Perhaps we need clarification from the authors. Thanks,
>
> Alex
>
Oh, good catch. Yeah, I think if you're going to remove the verbose
text, then the identifier should be 'SPDX-License-Identifier:
GPL-2.0-only' to match the verbose text you're removing.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-23 16:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-22 4:35 [PATCH] vfio-pci/zdev: Remove repeated verbose license text Cai Huoqing
2021-08-23 16:02 ` Matthew Rosato
2021-08-23 16:20 ` Alex Williamson
2021-08-23 16:26 ` Matthew Rosato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox