From: Yang Weijiang <weijiang.yang@intel.com>
To: pbonzini@redhat.com, jmattson@google.com, seanjc@google.com,
like.xu.linux@gmail.com, vkuznets@redhat.com,
wei.w.wang@intel.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Yang Weijiang <weijiang.yang@intel.com>
Subject: [PATCH v9 16/17] KVM: x86: Add Arch LBR MSR access interface
Date: Tue, 15 Feb 2022 16:25:43 -0500 [thread overview]
Message-ID: <20220215212544.51666-17-weijiang.yang@intel.com> (raw)
In-Reply-To: <20220215212544.51666-1-weijiang.yang@intel.com>
When userspace wants to access guest Arch LBR data MSRs, these
MSRs actually reside in guest FPU area, so need to load them to
HW before RDMSR and save them back into FPU area after WRMSR.
Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
---
arch/x86/kvm/vmx/pmu_intel.c | 10 ++++++++++
arch/x86/kvm/x86.c | 9 ++++++++-
2 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/pmu_intel.c b/arch/x86/kvm/vmx/pmu_intel.c
index e2cae30614b1..976789245917 100644
--- a/arch/x86/kvm/vmx/pmu_intel.c
+++ b/arch/x86/kvm/vmx/pmu_intel.c
@@ -431,6 +431,11 @@ static int intel_pmu_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
case MSR_ARCH_LBR_CTL:
msr_info->data = vmcs_read64(GUEST_IA32_LBR_CTL);
return 0;
+ case MSR_ARCH_LBR_FROM_0 ... MSR_ARCH_LBR_FROM_0 + 31:
+ case MSR_ARCH_LBR_TO_0 ... MSR_ARCH_LBR_TO_0 + 31:
+ case MSR_ARCH_LBR_INFO_0 ... MSR_ARCH_LBR_INFO_0 + 31:
+ kvm_get_xsave_msr(msr_info);
+ return 0;
default:
if ((pmc = get_gp_pmc(pmu, msr, MSR_IA32_PERFCTR0)) ||
(pmc = get_gp_pmc(pmu, msr, MSR_IA32_PMC0))) {
@@ -511,6 +516,11 @@ static int intel_pmu_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
(data & ARCH_LBR_CTL_LBREN))
intel_pmu_create_guest_lbr_event(vcpu);
return 0;
+ case MSR_ARCH_LBR_FROM_0 ... MSR_ARCH_LBR_FROM_0 + 31:
+ case MSR_ARCH_LBR_TO_0 ... MSR_ARCH_LBR_TO_0 + 31:
+ case MSR_ARCH_LBR_INFO_0 ... MSR_ARCH_LBR_INFO_0 + 31:
+ kvm_set_xsave_msr(msr_info);
+ return 0;
default:
if ((pmc = get_gp_pmc(pmu, msr, MSR_IA32_PERFCTR0)) ||
(pmc = get_gp_pmc(pmu, msr, MSR_IA32_PMC0))) {
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 64de3ed2cd74..de6fc8d4b500 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4105,7 +4105,14 @@ EXPORT_SYMBOL_GPL(kvm_set_xsave_msr);
*/
static bool is_xsaves_msr(u32 index)
{
- return false;
+ bool xsaves_msr = (index >= MSR_ARCH_LBR_FROM_0 &&
+ index <= MSR_ARCH_LBR_FROM_0 + 31) ||
+ (index >= MSR_ARCH_LBR_TO_0 &&
+ index <= MSR_ARCH_LBR_TO_0 + 31) ||
+ (index >= MSR_ARCH_LBR_INFO_0 &&
+ index <= MSR_ARCH_LBR_INFO_0 + 31);
+
+ return xsaves_msr;
}
/*
--
2.27.0
next prev parent reply other threads:[~2022-02-16 10:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 21:25 [PATCH v9 00/17] Introduce Architectural LBR for vPMU Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 01/17] KVM: x86: Report XSS as an MSR to be saved if there are supported features Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 02/17] KVM: x86: Refresh CPUID on writes to MSR_IA32_XSS Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 03/17] KVM: x86: Load guest fpu state when accessing MSRs managed by XSAVES Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 04/17] perf/x86/intel: Fix the comment about guest LBR support on KVM Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 05/17] perf/x86/lbr: Simplify the exposure check for the LBR_INFO registers Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 06/17] KVM: x86: Add Arch LBR MSRs to msrs_to_save_all list Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 07/17] KVM: vmx/pmu: Emulate MSR_ARCH_LBR_DEPTH for guest Arch LBR Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 08/17] KVM: vmx/pmu: Emulate MSR_ARCH_LBR_CTL " Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 09/17] KVM: x86/pmu: Refactor code to support " Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 10/17] KVM: x86: Refine the matching and clearing logic for supported_xss Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 11/17] KVM: x86: Add XSAVE Support for Architectural LBR Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 12/17] KVM: x86/vmx: Check Arch LBR config when return perf capabilities Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 13/17] KVM: nVMX: Add necessary Arch LBR settings for nested VM Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 14/17] KVM: x86/vmx: Clear Arch LBREn bit before inject #DB to guest Yang Weijiang
2022-02-15 21:25 ` [PATCH v9 15/17] KVM: x86/vmx: Flip Arch LBREn bit on guest state change Yang Weijiang
2022-02-15 21:25 ` Yang Weijiang [this message]
2022-02-15 21:25 ` [PATCH v9 17/17] KVM: x86/cpuid: Advertise Arch LBR feature in CPUID Yang Weijiang
2022-02-21 6:11 ` [PATCH v9 00/17] Introduce Architectural LBR for vPMU Yang, Weijiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215212544.51666-17-weijiang.yang@intel.com \
--to=weijiang.yang@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox