Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <andrew.jones@linux.dev>
To: Joey Gouly <joey.gouly@arm.com>
Cc: kvm@vger.kernel.org, alexandru.elisei@arm.com,
	eric.auger@redhat.com,  maz@kernel.org, kvmarm@lists.linux.dev,
	Oliver Upton <oliver.upton@linux.dev>
Subject: Re: [kvm-unit-tests PATCH v4 08/11] arm64: selftest: update test for running at EL2
Date: Thu, 4 Dec 2025 11:09:48 -0600	[thread overview]
Message-ID: <20251204-96632701672b23ff844ba300@orel> (raw)
In-Reply-To: <20251204142338.132483-9-joey.gouly@arm.com>

On Thu, Dec 04, 2025 at 02:23:35PM +0000, Joey Gouly wrote:
...
> +#if defined(__aarch64__)
> +	expected_level = current_level();
> +#endif

Another way to get rid of the #ifdef would be to create a test prep
function for each target in their already present #if areas;

arm's

 static void test_exception_prep(void) { }

arm64's

 static void test_exception_prep(void)
 {
     expected_level = current_level();
 }

and then just unconditionally call

 test_exception_prep()

in main.

Thanks,
drew

  reply	other threads:[~2025-12-04 17:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 14:23 [kvm-unit-tests PATCH v4 00/11] arm64: EL2 support Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 01/11] arm64: set SCTLR_EL1 to a known value for secondary cores Joey Gouly
2025-12-04 15:58   ` Andrew Jones
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 02/11] arm64: drop to EL1 if booted at EL2 Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 03/11] arm64: efi: initialise SCTLR_ELx fully Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 04/11] arm64: efi: initialise the EL Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 05/11] arm64: timer: use hypervisor timers when at EL2 Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 06/11] arm64: micro-bench: fix timer IRQ Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 07/11] arm64: micro-bench: use smc when at EL2 Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 08/11] arm64: selftest: update test for running " Joey Gouly
2025-12-04 17:09   ` Andrew Jones [this message]
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 09/11] arm64: pmu: count EL2 cycles Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 10/11] arm64: run at EL2 if supported Joey Gouly
2025-12-04 14:23 ` [kvm-unit-tests PATCH v4 11/11] arm64: add EL2 environment variable Joey Gouly
2025-12-04 17:17   ` Andrew Jones
2025-12-12 16:03     ` Joey Gouly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251204-96632701672b23ff844ba300@orel \
    --to=andrew.jones@linux.dev \
    --cc=alexandru.elisei@arm.com \
    --cc=eric.auger@redhat.com \
    --cc=joey.gouly@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox