Re: [kvm-unit-tests PATCH v4 11/11] arm64: add EL2 environment variable

[Joey Gouly <joey.gouly@arm.com>]

On Thu, Dec 04, 2025 at 11:17:24AM -0600, Andrew Jones wrote:
> On Thu, Dec 04, 2025 at 02:23:38PM +0000, Joey Gouly wrote:
> > This variable when set to y/Y will cause QEMU/kvmtool to start at EL2.
> > 
> > Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> > Acked-by: Marc Zyngier <maz@kernel.org>
> > Reviewed-by: Eric Auger <eric.auger@redhat.com>
> > ---
> >  arm/run | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arm/run b/arm/run
> > index 858333fc..dd641772 100755
> > --- a/arm/run
> > +++ b/arm/run
> > @@ -59,6 +59,10 @@ function arch_run_qemu()
> >  		M+=",highmem=off"
> >  	fi
> >  
> > +	if [ "$EL2" = "Y" ] || [ "$EL2" = "y" ]; then
> 
> I wanted to keep '1' and also add 'y' and 'Y'. We already allow those
> three (and only those three) in other places, see errata().

Couldn't find the errata() part, but I changed it to:

	if [ "$EL2" == "1" ] || [ "$EL2" = "Y" ] || [ "$EL2" = "y" ];


I also used test_exception_prep() like suggested in the other e-mail.

I will send out a next version next week, although I am aware it's very close
to holiday/vacation season!

Thanks,
Joey
> 
> Thanks,
> drew
> 
> > +		M+=",virtualization=on"
> > +	fi
> > +
> >  	if ! $qemu $M -device '?' | grep -q virtconsole; then
> >  		echo "$qemu doesn't support virtio-console for chr-testdev. Exiting."
> >  		exit 2
> > @@ -116,6 +120,9 @@ function arch_run_kvmtool()
> >  	fi
> >  
> >  	command="$(timeout_cmd) $kvmtool run"
> > +	if [ "$EL2" = "Y" ] || [ "$EL2" = "y" ]; then
> > +		command+=" --nested"
> > +	fi
> >  	if [ "$HOST" = "aarch64" ] && [ "$ARCH" = "arm" ]; then
> >  		run_test_status $command --kernel "$@" --aarch32
> >  	else
> > -- 
> > 2.25.1
> >