Re: [PATCH v5 02/20] vfio: Export various helpers from VFIO

[Vipin Sharma <vipinsh@google.com>]

On Tue, Jul 14, 2026 at 03:30:51PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing EXPORT_SYMBOL_GPL for vfio_pci_ops, violating the stated intent to export the variable for other modules.
> --
> 
> --- Patch [2]: [PATCH v5 02/20] vfio: Export various helpers from VFIO ---
> commit fcee4889ab47813a22592eb00c453edea425e0f0
> Author: Vipin Sharma <vipinsh@google.com>
> 
> vfio: Export various helpers from VFIO
> 
> This commit makes several vfio helpers and the vfio_pci_ops variable globally
> visible by removing their static declarations and adding them to headers. The
> stated intent is to export these symbols for use by other modules, such as
> the upcoming live update feature.
> 
> > diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> > index 0c771064c0b84..1fb4b276afe7c 100644
> > --- a/drivers/vfio/pci/vfio_pci.c
> > +++ b/drivers/vfio/pci/vfio_pci.c
> > @@ -125,7 +125,7 @@ static int vfio_pci_open_device(struct vfio_device *core_vdev)
> >  	return 0;
> >  }
> >  
> > -static const struct vfio_device_ops vfio_pci_ops = {
> > +const struct vfio_device_ops vfio_pci_ops = {
> >  	.name		= "vfio-pci",
> 
> [Severity: Low]
> The commit message states the intent is to "Export these functions and
> variable for other modules to use them", but is there a missing
> EXPORT_SYMBOL_GPL(vfio_pci_ops) here?
> 
> The other helpers modified in this patch received an EXPORT_SYMBOL_GPL() tag,
> but vfio_pci_ops did not. Without it, external modules attempting to reference
> vfio_pci_ops will fail with unresolved symbol errors during the build.
> 

We don't need EXPORT_SYMBOL_GPL() because it is accessed in
vfio_pci_liveupdate.c which is compiled in the same module vfio-pci.ko
which has the definition.

I could have done better job in the commit message log to explain this. I
will fix it in the next version.

> >  	.init		= vfio_pci_core_init_dev,
> >  	.release	= vfio_pci_core_release_dev,
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260714151505.3466855-1-vipinsh@google.com?part=2