Re: [PATCH v5 13/20] vfio: selftests: Build liveupdate library in VFIO selftests

[Vipin Sharma <vipinsh@google.com>]

On Tue, Jul 14, 2026 at 03:20:31PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The VFIO selftests Makefile includes a non-existent file `../liveupdate/lib/libliveupdate.mk`, which breaks the build.
> --
> 
> --- Patch [13]: [PATCH v5 13/20] vfio: selftests: Build liveupdate library in VFIO selftests ---
> commit 8a41a1e6305bdbe73648566ef65764a964e68dbb
> Author: Vipin Sharma <vipinsh@google.com>
> 
> vfio: selftests: Build liveupdate library in VFIO selftests
> 
> This commit imports and builds the liveupdate selftest library within the
> VFIO selftests to allow using liveupdate ioctls.
> 
> > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> > --- a/tools/testing/selftests/vfio/Makefile
> > +++ b/tools/testing/selftests/vfio/Makefile
> > @@ -21,6 +21,7 @@ TEST_FILES += scripts/setup.sh
> >  
> >  include ../lib.mk
> >  include lib/libvfio.mk
> > +include ../liveupdate/lib/libliveupdate.mk
> 
> [Severity: Low]
> Does this file exist in the tree? Including this missing file causes a fatal
> build error when running make in the vfio selftests directory because
> ../liveupdate/lib/libliveupdate.mk cannot be found. Was the liveupdate
> library intended to be added in a prerequisite patch that was missed?
> 

This is series is built on in-progress PCI Live Update series.
https://lore.kernel.org/linux-pci/20260710212616.1351130-1-dmatlack@google.com/

> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260714151505.3466855-1-vipinsh@google.com?part=13