Re: [PATCH v5 17/20] vfio: selftests: Add vfio_pci_liveupdate_kexec_test

[Vipin Sharma <vipinsh@google.com>]

On Tue, Jul 14, 2026 at 03:35:26PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing header and Makefile dependencies for liveupdate library.
> --
> 
> --- Patch [17]: [PATCH v5 17/20] vfio: selftests: Add vfio_pci_liveupdate_kexec_test ---
> commit 5f1d9fcb84decd9a67e94d71a492e75ba0113c1b
> Author: Vipin Sharma <vipinsh@google.com>
> 
> vfio: selftests: Add vfio_pci_liveupdate_kexec_test
> 
> This commit adds a new selftest to exercise preserving a vfio-pci device
> across a Live Update. The test verifies that the device file can be
> preserved before kexec and retrieved afterward.
> 
> > diff --git a/tools/testing/selftests/vfio/vfio_pci_liveupdate_kexec_test.c b/tools/testing/selftests/vfio/vfio_pci_liveupdate_kexec_test.c
> > new file mode 100644
> > index 0000000000000..15b3e3af91d1e
> > --- /dev/null
> > +++ b/tools/testing/selftests/vfio/vfio_pci_liveupdate_kexec_test.c
> > @@ -0,0 +1,89 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +
> > +#include <libliveupdate.h>
> 
> [Severity: Low]
> Does this header file exist in the tree? It looks like this could cause a
> build failure because libliveupdate.h cannot be found. The other liveupdate
> selftests appear to rely on luo_test_utils.h or direct ioctl calls instead
> of a libliveupdate library.
> 

This series is on top of in-progress PCI Live Update series.
https://lore.kernel.org/linux-pci/20260710212616.1351130-1-dmatlack@google.com/

Same for the below issues.

> [ ... ]
> 
> > +static void before_kexec(int luo_fd)
> > +{
> > +	struct vfio_pci_device *device;
> 
> [ ... ]
> 
> > +	printf("Preserving device in session\n");
> > +	ret = luo_session_preserve_fd(session_fd, device->fd, DEVICE_TOKEN);
> 
> [Severity: Low]
> Will this result in a linker error? It seems luo_session_preserve_fd is
> undefined without the accompanying library implementation. Should this test
> use direct ioctls or are there missing Makefile dependencies for a library?
> 
> [ ... ]
> 
> > +static void after_kexec(int luo_fd, int state_session_fd)
> > +{
> > +	struct vfio_pci_device *device;
> 
> [ ... ]
> 
> > +	printf("Retrieving the device FD from LUO\n");
> > +	device_fd = luo_session_retrieve_fd(session_fd, DEVICE_TOKEN);
> 
> [Severity: Low]
> Similarly here in after_kexec(), is luo_session_retrieve_fd implemented
> elsewhere in the test suite? It looks like this will also fail to link.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260714151505.3466855-1-vipinsh@google.com?part=17