From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: berrange@redhat.com, kchamart@redhat.com,
pierrick.bouvier@oss.qualcomm.com, peter.maydell@linaro.org,
mst@redhat.com, cohuck@redhat.com, pbonzini@redhat.com,
eblake@redhat.com, armbru@redhat.com,
lorenzo.pieralisi@linaro.org, gshan@redhat.com,
enju.kohei@fujitsu.com
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvm@vger.kernel.org,
mathieu.poirier@linaro.org
Subject: [RFC v3 19/24] hw/arm/virt: Move virt_flash_create() to machvirt_init()
Date: Tue, 25 Aug 2026 16:00:56 -0600 [thread overview]
Message-ID: <20260825220101.3443954-20-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <20260825220101.3443954-1-mathieu.poirier@linaro.org>
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
For confidential VMs we'll want to skip flash device creation.
Unfortunately, in virt_instance_init() the machine->cgs member has not
yet been initialized, so we cannot check whether confidential guest is
enabled. Move virt_flash_create() to machvirt_init(), where we can
access the machine->cgs member.
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
hw/arm/virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index c300224f19e7..966577d6a66f 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2861,6 +2861,8 @@ static void machvirt_init(MachineState *machine)
unsigned int smp_cpus = machine->smp.cpus;
unsigned int max_cpus = machine->smp.max_cpus;
+ virt_flash_create(vms);
+
possible_cpus = mc->possible_cpu_arch_ids(machine);
/*
@@ -4350,8 +4352,6 @@ static void virt_instance_init(Object *obj)
vms->virtio_transports = NUM_VIRTIO_TRANSPORTS;
- virt_flash_create(vms);
-
vms->oem_id = g_strndup(ACPI_BUILD_APPNAME6, 6);
vms->oem_table_id = g_strndup(ACPI_BUILD_APPNAME8, 8);
cxl_machine_init(obj, &vms->cxl_devices_state);
--
2.43.0
next prev parent reply other threads:[~2026-08-25 22:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 22:00 [RFC v3 00/24] Add Realm support to QEMU-VMM Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 01/24] linux-headers: Add RME related definitions Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 02/24] target/arm/kvm: Return immediately on error in kvm_arch_init() Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 03/24] target/arm: Add confidential guest support Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 04/24] target/arm/kvm-rme: Add mechanic to initialize realms Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 05/24] target/arm/kvm: Split kvm_arch_get/put_registers Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 06/24] target/arm/kvm-rme: Initialize vCPU Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 07/24] target/arm/kvm: Create scratch Realm VM when requested Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 08/24] target/arm/kvm: Use kvm_vm_check_extension() where necessary Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 09/24] hw/core/loader: Add a ROM loader notifier Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 10/24] target/arm/kvm-rme: Keep track of images loaded in Realm memory Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 11/24] target/arm/kvm-rme: Populate Realm with runtime images Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 12/24] target/arm/cpu: Set number of breakpoints and watchpoints in KVM Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 13/24] target/arm/cpu: Set number of PMU counters " Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 14/24] target/arm/cpu: Don't read Realm registers Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 15/24] hw/arm/virt: Set proper conduit method for Realms Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 16/24] hw/arm/virt: Embed Realm VM type with IPA address space Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 17/24] hw/arm/virt: Reserve one bit of guest physical address for RME Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 18/24] hw/arm/virt: Disable DTB randomness for confidential VMs Mathieu Poirier
2026-08-25 22:00 ` Mathieu Poirier [this message]
2026-08-25 22:00 ` [RFC v3 20/24] hw/arm/virt: Use RAM instead of flash for confidential guest firmware Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 21/24] target/arm/kvm-rme: Add DMA remapping for the shared memory region Mathieu Poirier
2026-08-25 22:00 ` [RFC v3 22/24] docs/interop/firmware.json: Add arm-rme firmware feature Mathieu Poirier
2026-08-25 22:01 ` [RFC v3 23/24] hw/arm/boot: Load DTB as is for confidential VMs Mathieu Poirier
2026-08-25 22:01 ` [RFC v3 24/24] hw/arm/boot: Skip bootloader for confidential guests Mathieu Poirier
2026-08-27 13:06 ` [RFC v3 00/24] Add Realm support to QEMU-VMM Daniel P. Berrangé
2026-08-27 13:28 ` Lorenzo Pieralisi
2026-09-01 13:20 ` Markus Armbruster
2026-09-02 15:45 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825220101.3443954-20-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=enju.kohei@fujitsu.com \
--cc=gshan@redhat.com \
--cc=kchamart@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lorenzo.pieralisi@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox