Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Logan Gunthorpe" <logang@deltatee.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, iommu@lists.linux.dev,
	"Tushar Dave" <tdave@nvidia.com>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org,
	kvm@vger.kernel.org, "Chaitanya Kulkarni" <kch@nvidia.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Alex Williamson" <alex@shazbot.org>,
	"Ankit Agrawal" <ankita@nvidia.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>
Subject: Re: [PATCH v9 01/18] PCI/P2PDMA: Document the TLP attribute assumptions
Date: Wed, 7 Oct 2026 15:12:57 -0500	[thread overview]
Message-ID: <20261007201257.GA781492@bhelgaas> (raw)
In-Reply-To: <20261001-fix-p2p-acs-v4-0-v9-1-1a8e0f50ddd9@nvidia.com>

On Thu, Oct 01, 2026 at 02:55:09PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> P2PDMA selects a mapping without receiving the Request's ordering or
> Address Type attributes. Its ACS handles only strictly ordered Requests
> carrying an Untranslated address.
> 
> Document that the result is not defined for Relaxed Ordering or
> ATS-translated Requests because those TLP attributes can select different
> routes through the fabric.
> 
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> Tested-by: Tushar Dave <tdave@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  Documentation/driver-api/pci/p2pdma.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/driver-api/pci/p2pdma.rst b/Documentation/driver-api/pci/p2pdma.rst
> index 63cff9e4d2c9..80f8fec9b0e9 100644
> --- a/Documentation/driver-api/pci/p2pdma.rst
> +++ b/Documentation/driver-api/pci/p2pdma.rst
> @@ -15,6 +15,13 @@ then based on the ACS settings the transaction can route entirely within
>  the PCIe hierarchy and never reach the root port. The kernel will evaluate
>  the PCIe topology and always permit P2P in these well-defined cases.
>  
> +This evaluation assumes clients issue strictly ordered Requests carrying an
> +Untranslated address. Its result is not defined when clients use Relaxed
> +Ordering or issue ATS-translated Requests because those TLP attributes can
> +select different routes through the fabric. Unless ACS Translation Blocking
> +is enabled, a Port with ACS Direct Translated P2P enabled routes a
> +Translated Request directly to the peer regardless of the redirect controls.

This whole paragraph is removed later in the series, so kudos for
documenting the current state before it changes :)

Unrelated to anything in this series, but this doc mentions
"p2p_provider", which doesn't exist.  Should it be "p2pdma_provider"?


  parent reply	other threads:[~2026-10-07 20:12 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01 11:55 [PATCH v9 00/18] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Leon Romanovsky
2026-10-01 11:55 ` [PATCH v9 01/18] PCI/P2PDMA: Document the TLP attribute assumptions Leon Romanovsky
2026-10-01 11:58   ` sashiko-bot
2026-10-07 20:12   ` Bjorn Helgaas [this message]
2026-10-01 11:55 ` [PATCH v9 02/18] PCI/P2PDMA: Derive routing from directional ACS controls Leon Romanovsky
2026-10-01 12:03   ` sashiko-bot
2026-10-06 20:49   ` Bjorn Helgaas
2026-10-07  6:32     ` Leon Romanovsky
2026-10-07 20:40       ` Bjorn Helgaas
2026-10-01 11:55 ` [PATCH v9 03/18] PCI: Reject unreadable ACS controls in isolation checks Leon Romanovsky
2026-10-01 12:05   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 04/18] PCI/P2PDMA: Evaluate ACS controls at the path divergence Leon Romanovsky
2026-10-01 12:02   ` sashiko-bot
2026-10-06 21:08   ` Bjorn Helgaas
2026-10-07 10:51     ` Leon Romanovsky
2026-10-01 11:55 ` [PATCH v9 05/18] PCI/P2PDMA: Document directional ACS routing Leon Romanovsky
2026-10-01 11:59   ` sashiko-bot
2026-10-01 15:25     ` Leon Romanovsky
2026-10-06 21:32   ` Bjorn Helgaas
2026-10-07 13:46     ` Leon Romanovsky
2026-10-07 20:10       ` Bjorn Helgaas
2026-10-01 11:55 ` [PATCH v9 06/18] PCI/P2PDMA: Collect the path's ACS controls before deciding Leon Romanovsky
2026-10-01 12:01   ` sashiko-bot
2026-10-06 21:48   ` Bjorn Helgaas
2026-10-07 13:50     ` Leon Romanovsky
2026-10-01 11:55 ` [PATCH v9 07/18] PCI/P2PDMA: Answer routing per TLP class Leon Romanovsky
2026-10-01 12:02   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 08/18] PCI/P2PDMA: Route Relaxed Ordering Completions directly Leon Romanovsky
2026-10-01 12:04   ` sashiko-bot
2026-10-06 22:21   ` Bjorn Helgaas
2026-10-01 11:55 ` [PATCH v9 09/18] PCI/P2PDMA: Reject Translated Requests blocked by Translation Blocking Leon Romanovsky
2026-10-01 12:04   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 10/18] PCI/P2PDMA: Route Translated Requests under Direct Translated P2P Leon Romanovsky
2026-10-01 12:02   ` sashiko-bot
2026-10-06 22:28   ` Bjorn Helgaas
2026-10-01 11:55 ` [PATCH v9 11/18] PCI/P2PDMA: Log detailed ACS routing diagnostics Leon Romanovsky
2026-10-01 12:06   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 12/18] PCI/P2PDMA: Add KUnit tests for the ACS routing decisions Leon Romanovsky
2026-10-01 12:01   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 13/18] PCI/P2PDMA: Test the ACS P2P routing walk Leon Romanovsky
2026-10-01 12:07   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 14/18] PCI: Add KUnit coverage for ACS isolation checks Leon Romanovsky
2026-10-01 12:02   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 15/18] PCI/P2PDMA: Document TLP-class routing Leon Romanovsky
2026-10-01 11:58   ` sashiko-bot
2026-10-01 11:55 ` [PATCH v9 16/18] PCI/P2PDMA: Let a client declare that it selects ATS per mapping Leon Romanovsky
2026-10-01 12:08   ` sashiko-bot
2026-10-01 12:59     ` Leon Romanovsky
2026-10-01 11:55 ` [PATCH v9 17/18] PCI/P2PDMA: Evaluate the ATS path for clients with ATS enabled Leon Romanovsky
2026-10-01 12:07   ` sashiko-bot
2026-10-01 15:23     ` Leon Romanovsky
2026-10-01 11:55 ` [PATCH v9 18/18] PCI/P2PDMA: Test the routing of " Leon Romanovsky
2026-10-01 12:04   ` sashiko-bot
2026-10-06 19:29 ` [PATCH v9 00/18] PCI/P2PDMA: Route peer-to-peer DMA by TLP class Bjorn Helgaas
2026-10-06 21:22   ` Leon Romanovsky
2026-10-06 21:36     ` Bjorn Helgaas
2026-10-07  6:56       ` Bjorn Helgaas
2026-10-07 10:54         ` Leon Romanovsky
2026-10-07 11:31           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007201257.GA781492@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=alex@shazbot.org \
    --cc=ankita@nvidia.com \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=christian.koenig@amd.com \
    --cc=corbet@lwn.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kch@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=leon@kernel.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=rdunlap@infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tdave@nvidia.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox