From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
berrange@redhat.com, kchamart@redhat.com,
pierrick.bouvier@oss.qualcomm.com, peter.maydell@linaro.org,
mst@redhat.com, cohuck@redhat.com, pbonzini@redhat.com,
eblake@redhat.com, armbru@redhat.com, jpb@kernel.org,
lorenzo.pieralisi@linaro.org
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvm@vger.kernel.org
Subject: Re: [RFC v1 20/25] hw/arm/virt: Move virt_flash_create() to machvirt_init()
Date: Wed, 8 Jul 2026 07:14:24 +0200 [thread overview]
Message-ID: <3cb18f9f-37d2-4e13-9333-65e5a65677db@oss.qualcomm.com> (raw)
In-Reply-To: <20260707224306.1202330-21-mathieu.poirier@linaro.org>
On 8/7/26 00:43, Mathieu Poirier wrote:
> From: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> For confidential VMs we'll want to skip flash device creation.
> Unfortunately, in virt_instance_init() the machine->cgs member has not
> yet been initialized, so we cannot check whether confidential guest is
> enabled. Move virt_flash_create() to machvirt_init(), where we can
> access the machine->cgs member.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> hw/arm/virt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
next prev parent reply other threads:[~2026-07-08 5:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 22:42 [RFC v1 00/25] Add Realm support to QEMU-VMM Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 01/25] linux-headers: Add RME related definitions Mathieu Poirier
2026-07-10 1:09 ` Gavin Shan
2026-07-10 7:36 ` Lorenzo Pieralisi
2026-07-10 10:46 ` Lorenzo Pieralisi
2026-07-07 22:42 ` [RFC v1 02/25] target/arm/kvm: Return immediately on error in kvm_arch_init() Mathieu Poirier
2026-07-08 5:08 ` Philippe Mathieu-Daudé
2026-07-07 22:42 ` [RFC v1 03/25] target/arm: Add confidential guest support Mathieu Poirier
2026-07-08 4:39 ` Markus Armbruster
2026-07-09 20:22 ` Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 04/25] target/arm/kvm-rme: Add mechanic to initialize realms Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 05/25] target/arm/kvm: Split kvm_arch_get/put_registers Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 06/25] target/arm/kvm-rme: Initialize vCPU Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 07/25] target/arm/kvm: Create scratch Realm VM when requested Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 08/25] target/arm/kvm: Use kvm_vm_check_extension() where necessary Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 09/25] target/arm/kvm-rme: Initialise Realm Initial Address space Mathieu Poirier
2026-07-09 23:44 ` Gavin Shan
2026-07-10 7:37 ` Lorenzo Pieralisi
2026-07-07 22:42 ` [RFC v1 10/25] hw/core/loader: Add a ROM loader notifier Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 11/25] target/arm/kvm-rme: Keep track of images loaded in Realm memory Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 12/25] target/arm/kvm-rme: Populate Realm with runtime images Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 13/25] target/arm/cpu: Set number of breakpoints and watchpoints in KVM Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 14/25] target/arm/cpu: Set number of PMU counters " Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 15/25] target/arm/cpu: Don't read Realm registers Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 16/25] hw/arm/virt: Set proper conduit method for Realms Mathieu Poirier
2026-07-08 5:12 ` Philippe Mathieu-Daudé
2026-07-07 22:42 ` [RFC v1 17/25] hw/arm/virt: Embed Realm VM type with IPA address space Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 18/25] hw/arm/virt: Reserve one bit of guest physical address for RME Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 19/25] hw/arm/virt: Disable DTB randomness for confidential VMs Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 20/25] hw/arm/virt: Move virt_flash_create() to machvirt_init() Mathieu Poirier
2026-07-08 5:14 ` Philippe Mathieu-Daudé [this message]
2026-07-07 22:43 ` [RFC v1 21/25] hw/arm/virt: Use RAM instead of flash for confidential guest firmware Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 22/25] target/arm/kvm-rme: Add DMA remapping for the shared memory region Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 23/25] docs/interop/firmware.json: Add arm-rme firmware feature Mathieu Poirier
2026-07-08 4:37 ` Markus Armbruster
2026-07-08 5:16 ` Philippe Mathieu-Daudé
2026-07-07 22:43 ` [RFC v1 24/25] hw/arm/boot: Load DTB as is for confidential VMs Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 25/25] hw/arm/boot: Skip bootloader for confidential guests Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb18f9f-37d2-4e13-9333-65e5a65677db@oss.qualcomm.com \
--to=philmd@oss.qualcomm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=eblake@redhat.com \
--cc=jpb@kernel.org \
--cc=kchamart@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lorenzo.pieralisi@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox