Re: [RFC v1 23/25] docs/interop/firmware.json: Add arm-rme firmware feature

[Markus Armbruster <armbru@redhat.com>]

Mathieu Poirier <mathieu.poirier@linaro.org> writes:

> From: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> Some distributions provide packages continaing firmware to be run under
> QEMU, such as "qemu-efi-aarch64" or "edk2-aarch64". Those packages also
> contain descriptors in /usr/share/qemu/firmware/*.json listing the
> firmware features, so that environments like libvirt can figure out
> which firmware they can load.
>
> Define an optional feature for arm64 firmware to indicate that a
> firmware supports running in a Realm. Firmware implementations need
> extra support for running in a Realm, in particular to distinguish
> shared from private guest memory.
>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  docs/interop/firmware.json | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/docs/interop/firmware.json b/docs/interop/firmware.json
> index 421bee0e5ed4..c68d7f5013f8 100644
> --- a/docs/interop/firmware.json
> +++ b/docs/interop/firmware.json
> @@ -161,6 +161,9 @@
>  #     options related to this feature are documented in
>  #     "docs/system/i386/amd-memory-encryption.rst".
>  #
> +# @arm-rme: The firmware supports running in a Realm, under the Arm Realm
> +#           Management Extension (RME).
> +#

Please format like this

   # @arm-rme: The firmware supports running in a Realm, under the Arm
   #     Realm Management Extension (RME).

>  # @intel-tdx: The firmware supports running under Intel Trust Domain
>  #     Extensions (TDX).
>  #
> @@ -229,7 +232,7 @@
>  { 'enum' : 'FirmwareFeature',
>    'data' : [ 'acpi-s3', 'acpi-s4',
>               'amd-sev', 'amd-sev-es', 'amd-sev-snp',
> -             'intel-tdx',
> +             'arm-rme', 'intel-tdx',
>               'enrolled-keys', 'requires-smm',
>               'secure-boot', 'host-uefi-vars',
>               'verbose-dynamic', 'verbose-static' ] }

With the formatting tidied up
Acked-by: Markus Armbruster <armbru@redhat.com>