Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
	berrange@redhat.com, kchamart@redhat.com,
	pierrick.bouvier@oss.qualcomm.com, peter.maydell@linaro.org,
	mst@redhat.com, cohuck@redhat.com, pbonzini@redhat.com,
	eblake@redhat.com, armbru@redhat.com, jpb@kernel.org,
	lorenzo.pieralisi@linaro.org, qemu-devel@nongnu.org,
	qemu-arm@nongnu.org, kvm@vger.kernel.org
Subject: Re: [RFC v1 01/25] linux-headers: Add RME related definitions
Date: Fri, 10 Jul 2026 09:36:54 +0200	[thread overview]
Message-ID: <alChFhS7HwGXcVh+@lpieralisi> (raw)
In-Reply-To: <03a39e32-3b15-49a3-a23a-782f8ba25466@redhat.com>

On Fri, Jul 10, 2026 at 11:09:43AM +1000, Gavin Shan wrote:
> On 7/8/26 8:42 AM, Mathieu Poirier wrote:
> > From: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > 
> > This is a temporary patch intended for testing purposes only. It provides
> > definitions related to supporting Realms by the QEMU-VMM.
> > 
> > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > ---
> >   linux-headers/asm-arm64/kvm.h |  9 +++++++++
> >   linux-headers/linux/kvm.h     | 21 +++++++++++++++++----
> >   2 files changed, 26 insertions(+), 4 deletions(-)
> > 
> > diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h
> > index 6aefe7973814..4c08631ec7d2 100644
> > --- a/linux-headers/asm-arm64/kvm.h
> > +++ b/linux-headers/asm-arm64/kvm.h
> > @@ -208,6 +208,15 @@ struct kvm_arm_counter_offset {
> >   	__u64 reserved;
> >   };
> > +#define KVM_ARM_RMI_POPULATE_FLAGS_MEASURE     (1 << 0)
> > +struct kvm_arm_rmi_populate {
> > +	__u64 base;
> > +	__u64 size;
> > +	__u64 source_uaddr;
> > +	__u32 flags;
> > +	__u32 reserved;
> > +};
> > +
> >   #define KVM_ARM_TAGS_TO_GUEST		0
> >   #define KVM_ARM_TAGS_FROM_GUEST		1
> > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> > index 50e87ed72c20..dae6e5ba8457 100644
> > --- a/linux-headers/linux/kvm.h
> > +++ b/linux-headers/linux/kvm.h
> > @@ -685,11 +685,21 @@ struct kvm_enable_cap {
> >   #define KVM_S390_SIE_PAGE_OFFSET 1
> >   /*
> > - * On arm64, machine type can be used to request the physical
> > - * address size for the VM. Bits[7-0] are reserved for the guest
> > - * PA size shift (i.e, log2(PA_Size)). For backward compatibility,
> > - * value 0 implies the default IPA size, 40bits.
> > + * On arm64, machine type can be used to request both the machine type and
> > + * the physical address size for the VM.
> > + *
> > + * Bits[31-30] are reserved for the ARM specific machine type.
> > + *
> > + * Bits[7-0] are reserved for the guest PA size shift (i.e, log2(PA_Size)).
> > + * For backward compatibility, value 0 implies the default IPA size, 40bits.
> >    */
> > +#define KVM_VM_TYPE_ARM_SHIFT		30
> > +#define KVM_VM_TYPE_ARM_MASK		(0x3ULL << KVM_VM_TYPE_ARM_SHIFT)
> > +#define KVM_VM_TYPE_ARM(_type)		\
> > +	(((_type) << KVM_VM_TYPE_ARM_SHIFT) & KVM_VM_TYPE_ARM_MASK)
> > +#define KVM_VM_TYPE_ARM_NORMAL		KVM_VM_TYPE_ARM(0)
> > +#define KVM_VM_TYPE_ARM_REALM		KVM_VM_TYPE_ARM(1)
> > +
> >   #define KVM_VM_TYPE_ARM_IPA_SIZE_MASK	0xffULL
> >   #define KVM_VM_TYPE_ARM_IPA_SIZE(x)		\
> >   	((x) & KVM_VM_TYPE_ARM_IPA_SIZE_MASK)
> 
> The definitions in this section aren't exactly same to that in (v14) host series,
> leading to KVM_VM_TYPE_ARM_REALM = 0 in my environment and the realm guest can't
> be started with the following error message. At least, KVM_VM_TYPE_ARM_MASK has
> been redefined with different values.
> 
>   qemu-system-aarch64: KVM does not support guest_memfd
> 
>   ----> linux-headers/linux/kvm.h
> 
>   #define KVM_VM_TYPE_ARM_SHIFT          30
>   #define KVM_VM_TYPE_ARM_MASK           (0x3ULL << KVM_VM_TYPE_ARM_SHIFT)
> 
>   #define KVM_VM_TYPE_ARM_MASK           (KVM_VM_TYPE_ARM_IPA_SIZE_MASK | \
>                                           KVM_VM_TYPE_ARM_PROTECTED)
> 
> After syncing the definitions with those in (v14) host series, I'm able to boot
> a simple realm guest (no virtio devices) with one warning.
> 
>   qemu-system-aarch64: Failed to enable KVM_CAP_ARM_NISV_TO_USER cap

Yep, that's correct the VM type handling has to be updated and I am looking
into the cap failure.

Thanks,
Lorenzo

> Thanks,
> Gavin
> 
> > @@ -719,6 +729,8 @@ struct kvm_enable_cap {
> >   #define KVM_GET_EMULATED_CPUID	  _IOWR(KVMIO, 0x09, struct kvm_cpuid2)
> >   #define KVM_GET_MSR_FEATURE_INDEX_LIST    _IOWR(KVMIO, 0x0a, struct kvm_msr_list)
> > +#define KVM_ARM_RMI_POPULATE	  _IOWR(KVMIO, 0xd7, struct kvm_arm_rmi_populate)
> > +
> >   /*
> >    * Extension capability list.
> >    */
> > @@ -985,6 +997,7 @@ struct kvm_enable_cap {
> >   #define KVM_CAP_S390_USER_OPEREXEC 246
> >   #define KVM_CAP_S390_KEYOP 247
> >   #define KVM_CAP_S390_VSIE_ESAMODE 248
> > +#define KVM_CAP_ARM_RMI 249
> >   struct kvm_irq_routing_irqchip {
> >   	__u32 irqchip;
> 

  reply	other threads:[~2026-07-10  7:37 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 22:42 [RFC v1 00/25] Add Realm support to QEMU-VMM Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 01/25] linux-headers: Add RME related definitions Mathieu Poirier
2026-07-10  1:09   ` Gavin Shan
2026-07-10  7:36     ` Lorenzo Pieralisi [this message]
2026-07-10 10:46     ` Lorenzo Pieralisi
2026-07-07 22:42 ` [RFC v1 02/25] target/arm/kvm: Return immediately on error in kvm_arch_init() Mathieu Poirier
2026-07-08  5:08   ` Philippe Mathieu-Daudé
2026-07-07 22:42 ` [RFC v1 03/25] target/arm: Add confidential guest support Mathieu Poirier
2026-07-08  4:39   ` Markus Armbruster
2026-07-09 20:22     ` Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 04/25] target/arm/kvm-rme: Add mechanic to initialize realms Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 05/25] target/arm/kvm: Split kvm_arch_get/put_registers Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 06/25] target/arm/kvm-rme: Initialize vCPU Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 07/25] target/arm/kvm: Create scratch Realm VM when requested Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 08/25] target/arm/kvm: Use kvm_vm_check_extension() where necessary Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 09/25] target/arm/kvm-rme: Initialise Realm Initial Address space Mathieu Poirier
2026-07-09 23:44   ` Gavin Shan
2026-07-10  7:37     ` Lorenzo Pieralisi
2026-07-07 22:42 ` [RFC v1 10/25] hw/core/loader: Add a ROM loader notifier Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 11/25] target/arm/kvm-rme: Keep track of images loaded in Realm memory Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 12/25] target/arm/kvm-rme: Populate Realm with runtime images Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 13/25] target/arm/cpu: Set number of breakpoints and watchpoints in KVM Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 14/25] target/arm/cpu: Set number of PMU counters " Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 15/25] target/arm/cpu: Don't read Realm registers Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 16/25] hw/arm/virt: Set proper conduit method for Realms Mathieu Poirier
2026-07-08  5:12   ` Philippe Mathieu-Daudé
2026-07-07 22:42 ` [RFC v1 17/25] hw/arm/virt: Embed Realm VM type with IPA address space Mathieu Poirier
2026-07-07 22:42 ` [RFC v1 18/25] hw/arm/virt: Reserve one bit of guest physical address for RME Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 19/25] hw/arm/virt: Disable DTB randomness for confidential VMs Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 20/25] hw/arm/virt: Move virt_flash_create() to machvirt_init() Mathieu Poirier
2026-07-08  5:14   ` Philippe Mathieu-Daudé
2026-07-07 22:43 ` [RFC v1 21/25] hw/arm/virt: Use RAM instead of flash for confidential guest firmware Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 22/25] target/arm/kvm-rme: Add DMA remapping for the shared memory region Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 23/25] docs/interop/firmware.json: Add arm-rme firmware feature Mathieu Poirier
2026-07-08  4:37   ` Markus Armbruster
2026-07-08  5:16   ` Philippe Mathieu-Daudé
2026-07-07 22:43 ` [RFC v1 24/25] hw/arm/boot: Load DTB as is for confidential VMs Mathieu Poirier
2026-07-07 22:43 ` [RFC v1 25/25] hw/arm/boot: Skip bootloader for confidential guests Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alChFhS7HwGXcVh+@lpieralisi \
    --to=lpieralisi@kernel.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=eblake@redhat.com \
    --cc=gshan@redhat.com \
    --cc=jpb@kernel.org \
    --cc=kchamart@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lorenzo.pieralisi@linaro.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox