[PATCH 1/2] KVM: PPC: 440: Implement mtdcrx

[PATCH 1/2] KVM: PPC: 440: Implement mtdcrx

[Alexander Graf]

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/44x_emulate.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c
index c8c6157..ea57631 100644
--- a/arch/powerpc/kvm/44x_emulate.c
+++ b/arch/powerpc/kvm/44x_emulate.c
@@ -28,6 +28,7 @@
 #include "44x_tlb.h"
 
 #define XOP_MFDCR   323
+#define XOP_MTDCRX  387
 #define XOP_MTDCR   451
 #define XOP_TLBSX   914
 #define XOP_ICCCI   966
@@ -84,6 +85,8 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu,
 
 			break;
 
+		case XOP_MTDCRX:
+			dcrn = kvmppc_get_gpr(vcpu, ra);
 		case XOP_MTDCR:
 			/* emulate some access in kernel */
 			switch (dcrn) {
-- 
1.6.0.2

[PATCH 2/2] KVM: PPC: 440: Implement mfdcrx

[Alexander Graf]

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 arch/powerpc/kvm/44x_emulate.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c
index ea57631..30ea3a7 100644
--- a/arch/powerpc/kvm/44x_emulate.c
+++ b/arch/powerpc/kvm/44x_emulate.c
@@ -27,6 +27,7 @@
 #include "booke.h"
 #include "44x_tlb.h"
 
+#define XOP_MFDCRX  259
 #define XOP_MFDCR   323
 #define XOP_MTDCRX  387
 #define XOP_MTDCR   451
@@ -50,6 +51,8 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu,
 	case 31:
 		switch (get_xop(inst)) {
 
+		case XOP_MFDCRX:
+			dcrn = kvmppc_get_gpr(vcpu, ra);
 		case XOP_MFDCR:
 			/* The guest may access CPR0 registers to determine the timebase
 			 * frequency, and it must know the real host frequency because it
-- 
1.6.0.2

Re: [PATCH 1/2] KVM: PPC: 440: Implement mtdcrx

[Avi Kivity]

On 08/16/2012 01:42 AM, Alexander Graf wrote:
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  arch/powerpc/kvm/44x_emulate.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c
> index c8c6157..ea57631 100644
> --- a/arch/powerpc/kvm/44x_emulate.c
> +++ b/arch/powerpc/kvm/44x_emulate.c
> @@ -28,6 +28,7 @@
>  #include "44x_tlb.h"
>  
>  #define XOP_MFDCR   323
> +#define XOP_MTDCRX  387
>  #define XOP_MTDCR   451
>  #define XOP_TLBSX   914
>  #define XOP_ICCCI   966
> @@ -84,6 +85,8 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu,
>  
>  			break;
>  
> +		case XOP_MTDCRX:
> +			dcrn = kvmppc_get_gpr(vcpu, ra);
>  		case XOP_MTDCR:

It's customary to put a /* fallthrough */ comment to shut down any
alarms that may be firing off in readers' minds.

-- 
error compiling committee.c: too many arguments to function

Re: [PATCH 1/2] KVM: PPC: 440: Implement mtdcrx

[Alexander Graf]

On 16.08.2012, at 11:11, Avi Kivity wrote:

> On 08/16/2012 01:42 AM, Alexander Graf wrote:
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>> ---
>> arch/powerpc/kvm/44x_emulate.c |    3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>> 
>> diff --git a/arch/powerpc/kvm/44x_emulate.c b/arch/powerpc/kvm/44x_emulate.c
>> index c8c6157..ea57631 100644
>> --- a/arch/powerpc/kvm/44x_emulate.c
>> +++ b/arch/powerpc/kvm/44x_emulate.c
>> @@ -28,6 +28,7 @@
>> #include "44x_tlb.h"
>> 
>> #define XOP_MFDCR   323
>> +#define XOP_MTDCRX  387
>> #define XOP_MTDCR   451
>> #define XOP_TLBSX   914
>> #define XOP_ICCCI   966
>> @@ -84,6 +85,8 @@ int kvmppc_core_emulate_op(struct kvm_run *run, struct kvm_vcpu *vcpu,
>> 
>> 			break;
>> 
>> +		case XOP_MTDCRX:
>> +			dcrn = kvmppc_get_gpr(vcpu, ra);
>> 		case XOP_MTDCR:
> 
> It's customary to put a /* fallthrough */ comment to shut down any
> alarms that may be firing off in readers' minds.

Yeah, I moved this over into function calls now. Makes the code easier to read :). And hopefully the compiler is smart enough to optimize it the same way.


Alex