From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Cc: Peter Xu <peterx@redhat.com>
Subject: intel_iommu unit test is also failing (was: Re: [PATCH kvm-unit-tests] realmode: load above stack)
Date: Mon, 4 May 2026 10:07:25 +0200 [thread overview]
Message-ID: <600b025e-602e-4128-9679-f53f32b96e8e@redhat.com> (raw)
In-Reply-To: <8aa24294-439f-4484-b6fc-9327b6fd0306@redhat.com>
On 04/05/2026 09.58, Thomas Huth wrote:
> On 04/06/2024 16.35, Paolo Bonzini wrote:
>> The bottom 32K of memory are generally reserved for use by the BIOS;
>> for example, traditionally the boot loader is placed at 0x7C00 and
>> the stack grows below that address.
>>
>> It turns out that with some versions of clang, realmode.flat has
>> become big enough that it overlaps the stack used by the multiboot
>> option ROM loader. The result is that a couple instructions are
>> overwritten. Typically one or two tests fail and that's it...
>>
>> Move the code above the forbidden region, in real 90s style.
>>
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> x86/realmode.lds | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/x86/realmode.lds b/x86/realmode.lds
>> index 0ed3063b..e4782a98 100644
>> --- a/x86/realmode.lds
>> +++ b/x86/realmode.lds
>> @@ -1,6 +1,6 @@
>> SECTIONS
>> {
>> - . = 16K;
>> + . = 32K;
>> stext = .;
>> .text : { *(.init) *(.text) }
>> . = ALIGN(4K);
>
> Hi Paolo!
>
> FYI, the realmode kvm-unit-test now also fails with the recent version of
> GCC 16 for the i386 target:
>
> https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/jobs/14195195727
>
> It was working fine some weeks ago with GCC 15.1:
>
> https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/jobs/13977260961
>
> When I apply your patch, the problem seems to be gone again in this case,
> but since there were some other issues with this (with older versions of
> GCC, I think):
>
> https://lore.kernel.org/kvm/49f8aadf-6e3f-4d2b-a32a-8ba941a3a2a1@redhat.com/
>
> ... there must be a better way to fix it?
>
> Could you please have a look?
By the way, the intel_iommu test now also suddenly started failing (for the
x86_64 target), either due to update of GCC or due to the update from QEMU
v10.2 to 11.0 :
https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/jobs/14195195728
Two weeks ago, it was still working fine:
https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/jobs/13977260962
Thomas
next prev parent reply other threads:[~2026-05-04 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240604143507.1041901-1-pbonzini@redhat.com>
2026-05-04 7:58 ` [PATCH kvm-unit-tests] realmode: load above stack Thomas Huth
2026-05-04 8:07 ` Thomas Huth [this message]
2026-05-04 15:45 ` intel_iommu unit test is also failing (was: Re: [PATCH kvm-unit-tests] realmode: load above stack) Peter Xu
2026-05-05 5:49 ` Clément MATHIEU--DRIF
2026-05-05 6:37 ` Clément MATHIEU--DRIF
2026-05-05 7:36 ` Clément MATHIEU--DRIF
2026-05-05 9:27 ` Clément MATHIEU--DRIF
2026-05-05 9:45 ` intel_iommu unit test is also failing Thomas Huth
2026-05-05 9:53 ` Clément MATHIEU--DRIF
2026-05-05 10:15 ` Thomas Huth
2026-05-05 10:23 ` Michael S. Tsirkin
2026-05-05 10:34 ` Thomas Huth
2026-05-05 10:53 ` Michael S. Tsirkin
2026-05-05 11:38 ` Thomas Huth
2026-05-05 12:33 ` Michael S. Tsirkin
2026-05-05 17:08 ` Thomas Huth
2026-05-05 11:39 ` Clément MATHIEU--DRIF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=600b025e-602e-4128-9679-f53f32b96e8e@redhat.com \
--to=thuth@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox