Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Christoph Schlameuss <schlameuss@linux.ibm.com>, kvm@vger.kernel.org
Cc: Janosch Frank <frankja@linux.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Jones <andrew.jones@linux.dev>,
	Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [kvm-unit-tests PATCH 3/3] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option
Date: Fri, 24 Apr 2026 09:31:53 +0200	[thread overview]
Message-ID: <6761d631-a714-420c-9c2f-258aec664d17@redhat.com> (raw)
In-Reply-To: <20260423-b4-cmdline-v1-3-f72ad0020d42@linux.ibm.com>

On 23/04/2026 16.16, Christoph Schlameuss wrote:
> b4 by default calls the get_maintainer.pl script with the
> '--nogit-chief-penguins' option letting the 'b4 prep --auto-to-cc' fail.
> 
> Adding parsing of that option without any related functionality to allow
> simple usage of b4 in the development workflow.
> 
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> 
> ---
> 
> Sorry, I am not too versed with perl, so if there are better ways to fix
> this please comment.
> ---
>   scripts/get_maintainer.pl | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 117b69145f0e..9b99f6218467 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -31,6 +31,7 @@ my $email_fixes = 1;
>   my $email_list = 1;
>   my $email_moderated_list = 1;
>   my $email_subscriber_list = 0;
> +my $email_git_chief_penguins = 0;

The variable is called email_git_penguin_chiefs in the kernel version of 
this script ... Could you please use that here, too, so we stay at least a 
little bit in sync with the kernel script?

  Thanks,
   Thomas


>   my $email_git = 0;
>   my $email_git_all_signature_types = 0;
>   my $email_git_blame = 0;
> @@ -228,6 +229,7 @@ if (!GetOptions(
>   		'git-blame!' => \$email_git_blame,
>   		'git-blame-signatures!' => \$email_git_blame_signatures,
>   		'git-fallback!' => \$email_git_fallback,
> +		'git-chief-penguins!' => \$email_git_chief_penguins,
>   		'git-min-signatures=i' => \$email_git_min_signatures,
>   		'git-max-maintainers=i' => \$email_git_max_maintainers,
>   		'git-min-percent=i' => \$email_git_min_percent,
> 


  reply	other threads:[~2026-04-24  7:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 14:16 [kvm-unit-tests PATCH 0/3] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
2026-04-23 14:16 ` [kvm-unit-tests PATCH 1/3] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
2026-04-24  7:00   ` Thomas Huth
2026-04-24  7:36     ` Christoph Schlameuss
2026-04-23 14:16 ` [kvm-unit-tests PATCH 2/3] scripts/checkpatch.pl: Copy kernel codespell file Christoph Schlameuss
2026-04-23 14:16 ` [kvm-unit-tests PATCH 3/3] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
2026-04-24  7:31   ` Thomas Huth [this message]
2026-04-24  7:41     ` Christoph Schlameuss
2026-04-24  7:19 ` [kvm-unit-tests PATCH 0/3] scripts: Configure and update tools to allow basic b4 usage Thomas Huth
2026-04-24  7:42   ` Christoph Schlameuss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6761d631-a714-420c-9c2f-258aec664d17@redhat.com \
    --to=thuth@redhat.com \
    --cc=andrew.jones@linux.dev \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=schlameuss@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox