Re: [kvm-unit-tests PATCH 3/3] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option

["Christoph Schlameuss" <schlameuss@linux.ibm.com>]

On Fri Apr 24, 2026 at 9:31 AM CEST, Thomas Huth wrote:
> On 23/04/2026 16.16, Christoph Schlameuss wrote:
>> b4 by default calls the get_maintainer.pl script with the
>> '--nogit-chief-penguins' option letting the 'b4 prep --auto-to-cc' fail.
>> 
>> Adding parsing of that option without any related functionality to allow
>> simple usage of b4 in the development workflow.
>> 
>> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
>> 
>> ---
>> 
>> Sorry, I am not too versed with perl, so if there are better ways to fix
>> this please comment.
>> ---
>>   scripts/get_maintainer.pl | 2 ++
>>   1 file changed, 2 insertions(+)
>> 
>> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
>> index 117b69145f0e..9b99f6218467 100755
>> --- a/scripts/get_maintainer.pl
>> +++ b/scripts/get_maintainer.pl
>> @@ -31,6 +31,7 @@ my $email_fixes = 1;
>>   my $email_list = 1;
>>   my $email_moderated_list = 1;
>>   my $email_subscriber_list = 0;
>> +my $email_git_chief_penguins = 0;
>
> The variable is called email_git_penguin_chiefs in the kernel version of 
> this script ... Could you please use that here, too, so we stay at least a 
> little bit in sync with the kernel script?
>
>   Thanks,
>    Thomas
>
>

Oh wow, good eye. That was my intend to have it the same as in the kernel
version. But obviously I can mess that up. Will fix. Thx.

>>   my $email_git = 0;
>>   my $email_git_all_signature_types = 0;
>>   my $email_git_blame = 0;
>> @@ -228,6 +229,7 @@ if (!GetOptions(
>>   		'git-blame!' => \$email_git_blame,
>>   		'git-blame-signatures!' => \$email_git_blame_signatures,
>>   		'git-fallback!' => \$email_git_fallback,
>> +		'git-chief-penguins!' => \$email_git_chief_penguins,
>>   		'git-min-signatures=i' => \$email_git_min_signatures,
>>   		'git-max-maintainers=i' => \$email_git_max_maintainers,
>>   		'git-min-percent=i' => \$email_git_min_percent,
>>