Re: [PATCH v2 15/28] arm64: Add ARM64_HAS_NV3 capability

[Marc Zyngier <maz@kernel.org>]

On Tue, 14 Jul 2026 10:40:00 +0100,
sashiko-bot@kernel.org wrote:
> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The newly added ARM64_HAS_NV3 capability lacks the required hardware detection logic, rendering it non-functional.
> --
> 
> --- Patch [15]: [PATCH v2 15/28] arm64: Add ARM64_HAS_NV3 capability ---
> commit 99ad2a0b713bc6373d924541643c7d6b05f45704
> Author: Marc Zyngier <maz@kernel.org>
> 
> arm64: Add ARM64_HAS_NV3 capability
> 
> This commit adds the ARM64_HAS_NV3 capability ID to the cpucaps list. It is
> intended to describe host support for FEAT_NV3 so that upcoming KVM code can
> depend on it being detected.
> 
> > diff --git a/arch/arm64/tools/cpucaps b/arch/arm64/tools/cpucaps
> > index 242dc211d8efa..7e0414509e89a 100644
> > --- a/arch/arm64/tools/cpucaps
> > +++ b/arch/arm64/tools/cpucaps
> > @@ -52,6 +52,7 @@ HAS_LSUI
> >  HAS_MOPS
> >  HAS_NESTED_VIRT
> >  HAS_NV2P1
> > +HAS_NV3
> 
> [Severity: Medium]
> Does this capability require a corresponding detection entry in the
> arm64_features array located in arch/arm64/kernel/cpufeature.c?
> 
> Without an entry in the arm64_features array to perform the hardware
> evaluation, the pointer in cpucap_ptrs for ARM64_HAS_NV3 remains NULL. 
> Could this cause any subsequent code checking this capability to always
> receive false, even on capable hardware?

Yes, on purpose. See the followup patch adding the detection code once
everything is in place.

	M.

-- 
Without deviation from the norm, progress is not possible.