Re: [PATCH v2 01/15] KVM: TDX: Drop kvm_x86_ops.link_external_spt()

[Sean Christopherson <seanjc@google.com>]

On Wed, May 27, 2026, Rick P Edgecombe wrote:
> On Wed, 2026-05-27 at 11:27 -0700, Sean Christopherson wrote:
> > > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > > [Rick: add in trivial feedback]
> > > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
> > > Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> > > ---
> > > MMU_refactors v2:
> > > - Moved this patch to the very beginning of the series so that when
> > >    warnings like "KVM_BUG_ON(!is_shadow_present_pte(new_spte), kvm)" are
> > >    removed from __tdp_mmu_set_spte_atomic() in TDP MMU in a later patch, the
> > >    atomic zap change can be propagated via the .set_external_spte() op.
> > >    (Yan).
> > > 
> > > MMU_refactors v1:
> > >   - rename external_spt->sept_pt (Rick, Yan)
> > 
> > Put the versioning info below the "---" that delineates the diff, otherwise
> > `git am` adds it to the changelog.
> 
> Hmm, it doesn't for me. The higher "---" gets picked up. Just tested on this
> patch and the version logs are dropped after git am.
> 
> I use format Yan has here to keep the version logs in the commit in the git
> tree. Then when sending out, it automatically gets dropped by the first applier.

I'm a dumbass.  I didn't apply these, I pulled down the github branch, because
I couldn't get them to apply cleanly.  /facepalm

Actually applying them does indeed work as intended.

Sorry, and thanks!