Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Jethro Beekman <jethro@fortanix.com>
Cc: "Jon Lange" <jlange@microsoft.com>,
	"Jörg Rödel" <joro@8bytes.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"thomas.lendacky" <thomas.lendacky@amd.com>,
	"Michael Roth" <michael.roth@amd.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"coconut-svsm@lists.linux.dev" <coconut-svsm@lists.linux.dev>,
	"Joerg Roedel" <joerg.roedel@amd.com>
Subject: Re: [EXTERNAL] Re: [PATCH 4/4] kvm: svm: Support KVM_SEV_SNP_PAGE_TYPE_VMSA at SNP_LAUNCH_UPDATE
Date: Tue, 23 Jun 2026 14:43:30 -0700	[thread overview]
Message-ID: <ajr-AigoW2cJY5k3@google.com> (raw)
In-Reply-To: <0657500d-a8bd-4dec-80a5-807e857a4306@fortanix.com>

On Tue, Jun 23, 2026, Jethro Beekman wrote:
> On 2026-06-23 16:51, Jon Lange wrote:
> > On Tuesday, June 23, 2026 6:40 AM, Sean Christopherson wrote:
> >> On Wed, Jun 17, 2026, Jörg Rödel wrote:
> >>> On Wed, Jun 17, 2026 at 06:37:52AM -0700, Sean Christopherson wrote:
> >>>> Ok, so it took us a few times to learn our lesson.  I still don't see that as a
> >>>> strong argument for new uAPI, especially not for VMSA pages.  I am very firmly
> >>>> of the opinion that letting anything but the host kernel configure the VMSA is
> >>>> beyond stupid, but unfortunately we're stuck with AP_CREATION.  Expanding that
> >>>> surface has a very, very, VERY high bar to get over.
> >>>
> >>> The strongest argument in my view (and the main reason we are doing this) is
> >>> actually the predictable launch measurement. On SEV-SNP this is a requirement
> >>> to use platform VM-identity features like the ID Block.
> >>
> >> And I'm saying that unless KVM *can't* provide a predictable launch measurement,
> >> which AIUI isn't the case, then the launch measurement *must* be stable across
> >> kernels because it's part of KVM's ABI.  So as I see it, the issue isn't that
> >> KVM is inherently unpredictable, it's that we lack tests to validate a thorny,
> >> subtle piece of KVM's ABI.
> > 
> > Joerg is suggesting that we need a launch measurement that is stable not
> > just across multiple launches on the same system, but across multiple
> > hypervisors.
> 
> If this is now suddenly an acceptable argument, please also merge https://lkml.org/lkml/2021/4/12/625

No, that's not how this works.  Dave and Jarkko both have unanswered questions
regarding the use case.  Answer their questions, and I'm confident you'll get
traction.

 : I don't believe we necessarily *WANT* or need Linux to support "all
 : possible ECREATE, EADD, EEXTEND, EINIT sequences".  Yet, it's what is
 : being used to justify this series without any other justification.
 : 
 : It's going to be a different story if you bring me a real enclave that
 : *REALLY* wants to do this for good reasons.

and

 : What specifically are you referring as the "rest of the world"?
 : 
 : That would be mean that there is reviewable workload "out there".

The start of that thread is *exactly* what's playing out here.  The big difference,
and why this one's likely getting a different result, is that Jon provided a very
thorough explanation of exactly what use case Joerg and company want to support.
The only "assumed knowledge" is why it's desirable for the measurement to be stable
across hypervisors, but I'm comfortable stitching that together on my own.

In other words, they aren't asking KVM to support every possible way/time a VMSA
could be associated with a vCPU, they're asking to extend KVM to support a concrete
use case, with meaningful real world impact.  In fact, I actually think this series
is *too* narrowly focused on their use case.

FWIW, KVM_TDX_INIT_MEM_REGION has almost the exact same ABI that SGX has: pages
contents are measured immediately after they're added.

  reply	other threads:[~2026-06-23 21:43 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 12:35 [PATCH 0/4] KVM: SEV: Support direct setting of VMSA for SEV-SNP guests Jörg Rödel
2026-06-11 12:35 ` [PATCH 1/4] kvm: svm: Streamline VMSA setting for VCPUs Jörg Rödel
2026-06-11 12:56   ` sashiko-bot
2026-06-11 14:13     ` Jörg Rödel
2026-06-16 20:52   ` Tom Lendacky
2026-06-23 10:55     ` Jörg Rödel
2026-06-23 20:18   ` Sean Christopherson
2026-06-11 12:35 ` [PATCH 2/4] kvm: svm: Defer VMSA allocation to LAUNCH_FINISH stage Jörg Rödel
2026-06-11 12:58   ` sashiko-bot
2026-06-11 14:29     ` Jörg Rödel
2026-06-16 21:33   ` Tom Lendacky
2026-06-23 11:26     ` Jörg Rödel
2026-06-11 12:35 ` [PATCH 3/4] kvm: svm: Support guest-provided VMSA for launching Jörg Rödel
2026-06-11 13:05   ` sashiko-bot
2026-06-11 14:43     ` Jörg Rödel
2026-06-16 21:48   ` Tom Lendacky
2026-06-23 11:36     ` Jörg Rödel
2026-06-23 21:07   ` Sean Christopherson
2026-06-11 12:35 ` [PATCH 4/4] kvm: svm: Support KVM_SEV_SNP_PAGE_TYPE_VMSA at SNP_LAUNCH_UPDATE Jörg Rödel
2026-06-11 12:43   ` Sean Christopherson
2026-06-11 13:23     ` Jörg Rödel
2026-06-16 17:55       ` Sean Christopherson
2026-06-17  6:45         ` Jörg Rödel
2026-06-17 13:00           ` Sean Christopherson
2026-06-17 13:25             ` Jörg Rödel
2026-06-17 13:37               ` Sean Christopherson
2026-06-17 14:44                 ` Jörg Rödel
2026-06-23 13:40                   ` Sean Christopherson
2026-06-23 14:44                     ` Jörg Rödel
2026-06-23 14:51                     ` [EXTERNAL] " Jon Lange
2026-06-23 20:23                       ` Sean Christopherson
2026-06-23 20:43                       ` Jethro Beekman
2026-06-23 21:43                         ` Sean Christopherson [this message]
2026-06-23 21:47                           ` Jethro Beekman
2026-06-23 22:02                             ` Sean Christopherson
2026-06-23 22:35                               ` Jethro Beekman
2026-06-23 22:55                                 ` Sean Christopherson
2026-06-23 23:08                                   ` Jethro Beekman
2026-06-17 13:18           ` James Bottomley
2026-06-17 13:28             ` Jörg Rödel
2026-06-17 13:45               ` James Bottomley
2026-06-17 14:53                 ` Jörg Rödel
2026-06-11 12:58   ` sashiko-bot
2026-06-11 15:23     ` Jörg Rödel
2026-06-16 22:11   ` Tom Lendacky
2026-06-23 11:48     ` Jörg Rödel
2026-06-23 21:29   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajr-AigoW2cJY5k3@google.com \
    --to=seanjc@google.com \
    --cc=coconut-svsm@lists.linux.dev \
    --cc=jethro@fortanix.com \
    --cc=jlange@microsoft.com \
    --cc=joerg.roedel@amd.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox