From: Brijesh Singh <brijesh.singh@amd.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: brijesh.singh@amd.com,
Alistair Francis <alistair.francis@xilinx.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@xilinx.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, Marcel Apfelbaum <marcel@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Borislav Petkov <bp@su
Subject: Re: [PATCH v7 26/26] qmp: add query-sev-launch-measure command
Date: Wed, 7 Feb 2018 12:12:25 -0600 [thread overview]
Message-ID: <dce6f9a2-e3e6-b75c-cc34-2fdfc30321f6@amd.com> (raw)
In-Reply-To: <14588677-a845-be1e-449f-901ade4a8fe6@redhat.com>
On 02/07/2018 10:29 AM, Eric Blake wrote:
...
>> +#
>> +# Since: 2.12
>> +#
>> +# Notes: If measurement is not available then a null measurement is
>> returned.
>
> Null measurement, as in empty string? Would it be better to have
> query-sev-launch-measure return an error instead of an
> SevLaunchMeasureInfo with a null measurement in that case?
>
Yes, an empty string when measurement is not available. I can certainly
change it to return an error when measurement is not available.
>> +##
>> +{ 'struct': 'SevLaunchMeasureInfo', 'data': {'data': 'str'} }
>> +
>> +##
>> +# @query-sev-launch-measure:
>> +#
>> +# Query the SEV guest launch information.
>> +#
>> +# Returns: The @SevLaunchMeasureInfo for the guest
>> +#
>> +# Since: 2.12
>> +#
>> +# Example:
>> +#
>> +# -> { "execute": "query-sev-launch-measure" }
>> +# <- { "return": { "data": "4l8LXeNlSPUDlXPJG5966/8%YZ" } }
>> +#
>
>
prev parent reply other threads:[~2018-02-07 18:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 16:06 [PATCH v7 01/26] memattrs: add debug attribute Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 02/26] exec: add ram_debug_ops support Brijesh Singh
2018-02-07 16:19 ` Eric Blake
2018-02-07 16:33 ` Brijesh Singh
2018-02-07 16:46 ` Eric Blake
2018-02-07 16:51 ` Paolo Bonzini
2018-02-07 20:26 ` Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 03/26] exec: add debug version of physical memory read and write API Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 04/26] monitor/i386: use debug APIs when accessing guest memory Brijesh Singh
2018-02-07 16:53 ` Paolo Bonzini
2018-02-07 16:06 ` [PATCH v7 05/26] target/i386: add memory encryption feature cpuid support Brijesh Singh
2018-02-07 16:54 ` Paolo Bonzini
2018-02-07 18:28 ` Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 06/26] machine: add -memory-encryption property Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 07/26] kvm: update kvm.h to include memory encryption ioctls Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 08/26] docs: add AMD Secure Encrypted Virtualization (SEV) Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 09/26] accel: add Secure Encrypted Virtulization (SEV) object Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 10/26] sev: add command to initialize the memory encryption context Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 11/26] sev: register the guest memory range which may contain encrypted data Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 12/26] kvm: introduce memory encryption APIs Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 13/26] qmp: add query-sev command Brijesh Singh
2018-02-07 16:22 ` Eric Blake
2018-02-07 16:36 ` Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 14/26] hmp: add 'info sev' command Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 15/26] sev: add command to create launch memory encryption context Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 16/26] sev: add command to encrypt guest memory region Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 17/26] target/i386: encrypt bios rom Brijesh Singh
2018-02-09 18:28 ` Dr. David Alan Gilbert
2018-02-09 20:49 ` Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 18/26] sev: add support to LAUNCH_MEASURE command Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 19/26] sev: Finalize the SEV guest launch flow Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 20/26] hw: i386: set ram_debug_ops when memory encryption is enabled Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 21/26] sev: add debug encrypt and decrypt commands Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 22/26] target/i386: clear C-bit when walking SEV guest page table Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 23/26] include: add psp-sev.h header file Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 24/26] sev: add support to query PLATFORM_STATUS command Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 25/26] sev: add support to KVM_SEV_GUEST_STATUS Brijesh Singh
2018-02-07 16:06 ` [PATCH v7 26/26] qmp: add query-sev-launch-measure command Brijesh Singh
2018-02-07 16:29 ` Eric Blake
2018-02-07 18:12 ` Brijesh Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce6f9a2-e3e6-b75c-cc34-2fdfc30321f6@amd.com \
--to=brijesh.singh@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@su \
--cc=cornelia.huck@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=edgar.iglesias@xilinx.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox