public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: David Matlack <dmatlack@google.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] x86: fix ept_access_test_paddr exit qualifications
Date: Fri, 12 May 2017 10:43:49 +0200	[thread overview]
Message-ID: <f7356232-5705-b62e-2c61-9811034616ac@redhat.com> (raw)
In-Reply-To: <20170505205723.39601-1-dmatlack@google.com>



On 05/05/2017 22:57, David Matlack wrote:
>  static void ept_access_test_paddr_read_only_ad_disabled(void)
>  {
> -	u64 qual = EPT_VLT_WR | EPT_VLT_PERM_RD;
> +	u64 qual = EPT_VLT_WR | EPT_VLT_RD | EPT_VLT_PERM_RD;

So this patch *was* correct after all.  Sorry. :)

I've added a comment here and in
ept_access_test_paddr_read_execute_ad_disabled:

	/*
	 * When EPT AD bits are disabled, all accesses to guest paging
	 * structures are reported separately as a read and (after
	 * translation of the GPA to host physical address) a read+write
	 * if the A/D bits have to be set.
	 */

then squashed everything and pushed to kvm-unit-tests.git master branch.

Thanks again!

Paolo

      parent reply	other threads:[~2017-05-12  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 20:57 [kvm-unit-tests PATCH] x86: fix ept_access_test_paddr exit qualifications David Matlack
2017-05-06  8:54 ` Paolo Bonzini
2017-05-11 18:41   ` David Matlack
2017-05-12  8:43 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7356232-5705-b62e-2c61-9811034616ac@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox