Re: [PATCH 09/15] KVM: arm64: Remove debug tracepoints

[Marc Zyngier <maz@kernel.org>]

On Sat, 09 Nov 2024 12:02:37 +0000,
Marc Zyngier <maz@kernel.org> wrote:
> 
> Whilst you're at it, how about:
> 
> diff --git a/arch/arm64/kvm/trace_handle_exit.h b/arch/arm64/kvm/trace_handle_exit.h
> index 064a58c19f481..fa1e48a36d3f9 100644
> --- a/arch/arm64/kvm/trace_handle_exit.h
> +++ b/arch/arm64/kvm/trace_handle_exit.h
> @@ -101,26 +101,6 @@ TRACE_EVENT(kvm_arm_set_dreg32,
>  
>  TRACE_DEFINE_SIZEOF(__u64);
>  
> -TRACE_EVENT(kvm_arm_set_regset,
> -	TP_PROTO(const char *type, int len, __u64 *control, __u64 *value),
> -	TP_ARGS(type, len, control, value),
> -	TP_STRUCT__entry(
> -		__field(const char *, name)
> -		__field(int, len)
> -		__array(u64, ctrls, 16)
> -		__array(u64, values, 16)
> -	),
> -	TP_fast_assign(
> -		__entry->name = type;
> -		__entry->len = len;
> -		memcpy(__entry->ctrls, control, len << 3);
> -		memcpy(__entry->values, value, len << 3);
> -	),
> -	TP_printk("%d %s CTRL:%s VALUE:%s", __entry->len, __entry->name,
> -		__print_array(__entry->ctrls, __entry->len, sizeof(__u64)),
> -		__print_array(__entry->values, __entry->len, sizeof(__u64)))
> -);
> -
>  TRACE_EVENT(trap_reg,
>  	TP_PROTO(const char *fn, int reg, bool is_write, u64 write_value),
>  	TP_ARGS(fn, reg, is_write, write_value),
> 
> It's not like we're going to miss that.

Same thing for kvm_arm_set_dreg32(), by the way. Hopefully nobody will
notice.

	M.

-- 
Without deviation from the norm, progress is not possible.