Re: [PATCH 08/15] KVM: arm64: Select debug state to save/restore based on debug owner

[Oliver Upton <oliver.upton@linux.dev>]

On Sat, Nov 09, 2024 at 11:57:46AM +0000, Marc Zyngier wrote:
> > +#define vcpu_debug_regs(vcpu)					\
> > +({								\
> > +	struct kvm_guest_debug_arch *__d;			\
> > +								\
> > +	switch ((vcpu)->arch.debug_owner) {			\
> > +	case VCPU_DEBUG_FREE:					\
> > +		WARN_ON_ONCE(1);				\
> > +		fallthrough;					\
> > +	case VCPU_DEBUG_GUEST_OWNED:				\
> > +		__d = &(vcpu)->arch.vcpu_debug_state;		\
> > +		break;						\
> > +	case VCPU_DEBUG_HOST_OWNED:				\
> > +		__d = &(vcpu)->arch.external_debug_state;	\
> > +		break;						\
> > +	}							\
> > +								\
> > +	__d;							\
> > +})
> 
> Any particular reason why this can't be an actual function? Or at
> least a function taking a kvm_ vcpu_arch as a parameter, and a
> preprocessor wrapper for the vcpu->arch pointer chasing?

None, I'll actually just throw this whole thing into debug-sr.h as a
function.

I wasn't sure if I was going to keep the tracepoints around at the time
I did this, so I needed an implementation I could use in the kernel side
of things as well.

-- 
Thanks,
Oliver