Vjhc patch

Vjhc patch

[Tommy McCabe]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Gets rid of the function to define a function which
causes errors in elksnet/ktcp/vjhc.c.


		
__________________________________
Do you Yahoo!?
Vote for the stars of Yahoo!'s next ad campaign!
http://advision.webevents.yahoo.com/yahoo/votelifeengine/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: vjhc.diff --]
[-- Type: text/x-diff; name="vjhc.diff", Size: 696 bytes --]

--- ./elkscomp/elksnet/ktcp/vjhc.c	2002-07-28 11:45:45.000000000 -0400
+++ ./elkscurr/elksnet/ktcp/vjhc.c	2004-07-17 19:46:40.000000000 -0400
@@ -113,10 +113,8 @@
 	}
 }
 
-DEFUN
-(int ip_vjhc_compress, (pkt),
-	pkt_ut *pkt
-)
+int ip_vjhc_compress(pkt_ut *pkt)
+
 {
 	iphdr_t *ip_hdr, *oip_hdr;
 	tcphdr_t *tcp_hdr, *otcp_hdr;
@@ -388,10 +386,8 @@
 	return PPP_TYPE_VJHC_COMPR;
 }
 
-DEFUN
-(void ip_vjhc_arr_uncompr, (pkt),
-	pkt_ut *pkt
-)
+void ip_vjhc_arr_uncompr(pkt_ut *pkt)
+
 {
 	rcv_state_ut *state;
 	iphdr_t *ip_hdr;
@@ -430,10 +426,8 @@
 
 }
 
-DEFUN
-(void ip_vjhc_arr_compr, (pkt),
-	pkt_ut *pkt
-)
+void ip_vjhc_arr_compr(pkt_ut *pkt)
+
 {
 	iphdr_t *ip_hdr;
 	tcphdr_t *tcp_hdr;

Re: Vjhc patch

[Eduardo Pereira Habkost]

[-- Attachment #1: Type: text/plain, Size: 1756 bytes --]

On Sat, Jul 17, 2004 at 04:51:33PM -0700, Tommy McCabe wrote:
> Gets rid of the function to define a function which
> causes errors in elksnet/ktcp/vjhc.c.

I guess that there was a reason to use DEFUN(), probably due to support
of different function declaration styles, on different compilers. If we
choose to remove DEFUN(), I guess that we should remove because we know
it is not needed for anything, not because of building errors that can
be caused by errors in other places, not by the use of DEFUN().

And, if you get errors when building, I think that is good to show which
erros you see. It is not possible to review your fixes, if we don't know
what is the real reason for you making those changes.

For example: ktcp builds without problems here, so I am very interested
to see why do you get errors on your system, but I don't see any errors
here. Could you show us the error messages?


> --- ./elkscomp/elksnet/ktcp/vjhc.c	2002-07-28 11:45:45.000000000 -0400
> +++ ./elkscurr/elksnet/ktcp/vjhc.c	2004-07-17 19:46:40.000000000 -0400
> @@ -113,10 +113,8 @@
>  	}
>  }
>  
> -DEFUN
> -(int ip_vjhc_compress, (pkt),
> -	pkt_ut *pkt
> -)
> +int ip_vjhc_compress(pkt_ut *pkt)
> +
>  {
>  	iphdr_t *ip_hdr, *oip_hdr;
>  	tcphdr_t *tcp_hdr, *otcp_hdr;
> @@ -388,10 +386,8 @@
>  	return PPP_TYPE_VJHC_COMPR;
>  }
>  
> -DEFUN
> -(void ip_vjhc_arr_uncompr, (pkt),
> -	pkt_ut *pkt
> -)
> +void ip_vjhc_arr_uncompr(pkt_ut *pkt)
> +
>  {
>  	rcv_state_ut *state;
>  	iphdr_t *ip_hdr;
> @@ -430,10 +426,8 @@
>  
>  }
>  
> -DEFUN
> -(void ip_vjhc_arr_compr, (pkt),
> -	pkt_ut *pkt
> -)
> +void ip_vjhc_arr_compr(pkt_ut *pkt)
> +
>  {
>  	iphdr_t *ip_hdr;
>  	tcphdr_t *tcp_hdr;


-- 
Eduardo

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Vjhc patch

[Tommy McCabe]

--- Eduardo Pereira Habkost
<ehabkost@conectiva.com.br> wrote:
> On Sat, Jul 17, 2004 at 04:51:33PM -0700, Tommy
> McCabe wrote:
> > Gets rid of the function to define a function
> which
> > causes errors in elksnet/ktcp/vjhc.c.
> 
> I guess that there was a reason to use DEFUN(),
> probably due to support
> of different function declaration styles, on
> different compilers. If we
> choose to remove DEFUN(), I guess that we should
> remove because we know
> it is not needed for anything, not because of
> building errors that can
> be caused by errors in other places, not by the use
> of DEFUN().
> 
> And, if you get errors when building, I think that
> is good to show which
> erros you see. It is not possible to review your
> fixes, if we don't know
> what is the real reason for you making those
> changes.
> 
> For example: ktcp builds without problems here, so I
> am very interested
> to see why do you get errors on your system, but I
> don't see any errors
> here. Could you show us the error messages?

Look at vjhc.h. There are two definitions of DEFUN,
depending on some parameter. One defines a function.
The other doesn't. For some reason, the parameter got
changed over the years, so now anything using DEFUn
comes out as gibberish to the compiler.

> > --- ./elkscomp/elksnet/ktcp/vjhc.c	2002-07-28
> 11:45:45.000000000 -0400
> > +++ ./elkscurr/elksnet/ktcp/vjhc.c	2004-07-17
> 19:46:40.000000000 -0400
> > @@ -113,10 +113,8 @@
> >  	}
> >  }
> >  
> > -DEFUN
> > -(int ip_vjhc_compress, (pkt),
> > -	pkt_ut *pkt
> > -)
> > +int ip_vjhc_compress(pkt_ut *pkt)
> > +
> >  {
> >  	iphdr_t *ip_hdr, *oip_hdr;
> >  	tcphdr_t *tcp_hdr, *otcp_hdr;
> > @@ -388,10 +386,8 @@
> >  	return PPP_TYPE_VJHC_COMPR;
> >  }
> >  
> > -DEFUN
> > -(void ip_vjhc_arr_uncompr, (pkt),
> > -	pkt_ut *pkt
> > -)
> > +void ip_vjhc_arr_uncompr(pkt_ut *pkt)
> > +
> >  {
> >  	rcv_state_ut *state;
> >  	iphdr_t *ip_hdr;
> > @@ -430,10 +426,8 @@
> >  
> >  }
> >  
> > -DEFUN
> > -(void ip_vjhc_arr_compr, (pkt),
> > -	pkt_ut *pkt
> > -)
> > +void ip_vjhc_arr_compr(pkt_ut *pkt)
> > +
> >  {
> >  	iphdr_t *ip_hdr;
> >  	tcphdr_t *tcp_hdr;
> 
> 
> -- 
> Eduardo
> 

> ATTACHMENT part 2 application/pgp-signature 




		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail 

Re: Vjhc patch

[Eduardo Pereira Habkost]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Mon, Jul 19, 2004 at 10:53:41AM -0700, Tommy McCabe wrote:
<snip>
> 
> Look at vjhc.h. There are two definitions of DEFUN,
> depending on some parameter. One defines a function.
> The other doesn't. For some reason, the parameter got
> changed over the years, so now anything using DEFUn
> comes out as gibberish to the compiler.

The first one uses ansi function declaration, the other K&R function
declarations. DEFUN is used to make vjhc support both.

I can't see where is the error. As I said before: ktcp (including vjhc.c)
builds cleanly on my system, and I would like to know which error occurs
on your system.

-- 
Eduardo

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Vjhc patch

[Tommy McCabe]

--- Eduardo Pereira Habkost
<ehabkost@conectiva.com.br> wrote:
> On Mon, Jul 19, 2004 at 10:53:41AM -0700, Tommy
> McCabe wrote:
> <snip>
> > 
> > Look at vjhc.h. There are two definitions of
> DEFUN,
> > depending on some parameter. One defines a
> function.
> > The other doesn't. For some reason, the parameter
> got
> > changed over the years, so now anything using
> DEFUn
> > comes out as gibberish to the compiler.
> 
> The first one uses ansi function declaration, the
> other K&R function
> declarations. DEFUN is used to make vjhc support
> both.
>
> I can't see where is the error. As I said before:
> ktcp (including vjhc.c)
> builds cleanly on my system, and I would like to
> know which error occurs
> on your system.

1. What version of ELKS and BCC do you have?
2. Did you turn on SLIP header compression in the ELKS
kernel config?

> -- 
> Eduardo
> 

> ATTACHMENT part 2 application/pgp-signature 




		
__________________________________
Do you Yahoo!?
Vote for the stars of Yahoo!'s next ad campaign!
http://advision.webevents.yahoo.com/yahoo/votelifeengine/

Re: Vjhc patch

[Eduardo Pereira Habkost]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]


Things would be easier if you just show which error is occurring on
your system.  :)

On Mon, Jul 19, 2004 at 11:51:17AM -0700, Tommy McCabe wrote:
<snip>
> 
> 1. What version of ELKS and BCC do you have?

elks from current CVS
bcc from dev86-0.16.16

> 2. Did you turn on SLIP header compression in the ELKS
> kernel config?

No. I can check using CONFIG_CSLIP=y later.

-- 
Eduardo

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Vjhc patch

[Tommy McCabe]

--- Eduardo Pereira Habkost
<ehabkost@conectiva.com.br> wrote:
> 
> Things would be easier if you just show which error
> is occurring on
> your system.  :)
> 
> On Mon, Jul 19, 2004 at 11:51:17AM -0700, Tommy
> McCabe wrote:
> <snip>
> > 
> > 1. What version of ELKS and BCC do you have?
> 
> elks from current CVS
> bcc from dev86-0.16.16
> 
> > 2. Did you turn on SLIP header compression in the
> ELKS
> > kernel config?
> 
> No. I can check using CONFIG_CSLIP=y later.

No wonder. vjhc.c is the program that does CSLIP
header compression.

> -- 
> Eduardo
> 

> ATTACHMENT part 2 application/pgp-signature 




		
__________________________________
Do you Yahoo!?
Vote for the stars of Yahoo!'s next ad campaign!
http://advision.webevents.yahoo.com/yahoo/votelifeengine/