Re: Another patch

[Eduardo Pereira Habkost <ehabkost@conectiva.com.br>]

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

On Tue, Jul 27, 2004 at 07:54:25AM -0600, Miguel Bolanos wrote:
> Greetings,
> 
> On Mon, 2004-07-12 at 15:41, Tommy McCabe wrote:
> > This patch:
> > 
> > 1. Has eight partitions per hard disk instead of 64,
> > to save indoes and not flood the disk images. This
> > time I didn't change the commented-out stuff like the
> > secondary IDE channel.
> 
> I would like to hear out some votes about this before actually applying
> it.. in my personal opinion it should go, but perhaps anyone have a
> different opinion? (Allan? Harry? Claudio? ... ?)

The patch breaks the major/minor numbers on MAKEDEV.

> 
> > 
> > 2. Remove the Conrad Parallel Port Radio Clock (which
> > I think is some sort of easter egg) from MAKEDEV.
> > 
> 
> sort of an easter egg... interesting definition.
> Honestly i can't just a feature with that justification.

I agree. We can comment it, as the device is not used. Our problem is
that MAKEDEV makes too many devices by default and waste inodes on
the root disk. Comment out devices that are not obviously used, can
help. Maybe we can have a "--few-inodes" option or something like that,
for building the root disks.

> 
> > 3. Fixed the "make clean" process.
> > 
> 
> Applied the rootfs_template.tar fix.

Did you removed the warnings? The warning is there to tell the user that
make clean is a little broken (it doesn't restore the previous state of
rootfs_template), so we need to fix that, not remove the warning.

> 
> > 4. Got rid of the sudos in the Makefile.
> > 
> 
> Definitly applied, BUT.. keeping the mount commands.

Of course.

> 
> > 5. Got rid of the ridiculous business with a ROOTDIR
> > that didn't exist and commands that weren't referenced
> > anywhere in the Makefile.
> > 

Huh? I didn't get your point, Tommy. Please detail your changes, and
explain the real reason, not just because you think it looks better,
or it is "ridiculous".

> 
> NOT applied. 
> 
> best wishes
> 
> Mike
> 

-- 
Eduardo

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]