* [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls
@ 2019-06-25 5:15 luanshi
2019-07-05 9:42 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: luanshi @ 2019-06-25 5:15 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-acpi, James Morse, Tony Luck, Borislav Petkov
Function __ghes_check_estatus() is always called after
__ghes_peek_estatus(), but it is already called in __ghes_peek_estatus().
So we should remove some needless __ghes_check_estatus() calls.
Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
Reviewed-by: James Morse <james.morse@arm.com>
---
drivers/acpi/apei/ghes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index 993940d..a66e00f 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -345,7 +345,7 @@ static int __ghes_peek_estatus(struct ghes *ghes,
return -ENOENT;
}
- return __ghes_check_estatus(ghes, estatus);
+ return 0;
}
static int __ghes_read_estatus(struct acpi_hest_generic_status *estatus,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls
2019-06-25 5:15 [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls luanshi
@ 2019-07-05 9:42 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2019-07-05 9:42 UTC (permalink / raw)
To: luanshi; +Cc: Len Brown, linux-acpi, James Morse, Tony Luck, Borislav Petkov
On Tuesday, June 25, 2019 7:15:28 AM CEST luanshi wrote:
> Function __ghes_check_estatus() is always called after
> __ghes_peek_estatus(), but it is already called in __ghes_peek_estatus().
> So we should remove some needless __ghes_check_estatus() calls.
>
> Signed-off-by: Liguang Zhang <zhangliguang@linux.alibaba.com>
> Reviewed-by: James Morse <james.morse@arm.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 993940d..a66e00f 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -345,7 +345,7 @@ static int __ghes_peek_estatus(struct ghes *ghes,
> return -ENOENT;
> }
>
> - return __ghes_check_estatus(ghes, estatus);
> + return 0;
> }
>
> static int __ghes_read_estatus(struct acpi_hest_generic_status *estatus,
>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-05 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-25 5:15 [PATCH v3] ACPI / APEI: Remove needless __ghes_check_estatus() calls luanshi
2019-07-05 9:42 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox