From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Punit Agrawal <punit.agrawal@arm.com>, bp@suse.de
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
tbaicar@codeaurora.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] acpi/apei: Fix in-correct return value
Date: Fri, 21 Oct 2016 23:28:29 +0200 [thread overview]
Message-ID: <1979931.ATDSke4qB1@vostro.rjw.lan> (raw)
In-Reply-To: <20161018160719.31252-1-punit.agrawal@arm.com>
On Tuesday, October 18, 2016 05:07:19 PM Punit Agrawal wrote:
> Although ghes_proc tests for error while reading the error status, it
> always return success (0). Fix this by propagating the return value.
>
> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support")
> Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index f0a029e..0d099a2 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
> ghes_do_proc(ghes, ghes->estatus);
> out:
> ghes_clear_estatus(ghes);
> - return 0;
> + return rc;
> }
>
> static void ghes_add_timer(struct ghes *ghes)
>
Boris, all fine here?
Thanks,
Rafael
next prev parent reply other threads:[~2016-10-21 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 16:07 [PATCH] acpi/apei: Fix in-correct return value Punit Agrawal
2016-10-20 19:51 ` Baicar, Tyler
2016-10-21 14:58 ` Punit Agrawal
2016-10-21 21:28 ` Rafael J. Wysocki [this message]
2016-10-22 16:37 ` Borislav Petkov
2016-10-23 0:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1979931.ATDSke4qB1@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=tbaicar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox