From: Borislav Petkov <bp@suse.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Punit Agrawal <punit.agrawal@arm.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
tbaicar@codeaurora.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] acpi/apei: Fix in-correct return value
Date: Sat, 22 Oct 2016 18:37:35 +0200 [thread overview]
Message-ID: <20161022163735.emhpdrzfbyys7rcp@pd.tnic> (raw)
In-Reply-To: <1979931.ATDSke4qB1@vostro.rjw.lan>
On Fri, Oct 21, 2016 at 11:28:29PM +0200, Rafael J. Wysocki wrote:
> Boris, all fine here?
Short answer: Yeah, looks ok to me.
Longer answer: I mean, this way ghes_proc() *actually* propagates the
return value of ghes_read_estatus() and we don't do any processing if it
failed.
Which doesn't really tell me a whole lot about the actual processing,
i.e., what ghes_do_proc() did.
But ghes_do_proc() doesn't return anything and ghes_proc()'s retval is
used only in contexts where we're asking whether something got processed
or not.
And for that, that fix is adequate. So:
Reviewed-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-10-22 16:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 16:07 [PATCH] acpi/apei: Fix in-correct return value Punit Agrawal
2016-10-20 19:51 ` Baicar, Tyler
2016-10-21 14:58 ` Punit Agrawal
2016-10-21 21:28 ` Rafael J. Wysocki
2016-10-22 16:37 ` Borislav Petkov [this message]
2016-10-23 0:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161022163735.emhpdrzfbyys7rcp@pd.tnic \
--to=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=punit.agrawal@arm.com \
--cc=rjw@rjwysocki.net \
--cc=tbaicar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox