From: Punit Agrawal <punit.agrawal@arm.com>
To: "Baicar, Tyler" <tbaicar@codeaurora.org>
Cc: linux-acpi@vger.kernel.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, bp@suse.de,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] acpi/apei: Fix in-correct return value
Date: Fri, 21 Oct 2016 15:58:15 +0100 [thread overview]
Message-ID: <877f9121h4.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <a159bf94-223b-7ec5-b4a5-16ab65662e1e@codeaurora.org> (Tyler Baicar's message of "Thu, 20 Oct 2016 13:51:31 -0600")
"Baicar, Tyler" <tbaicar@codeaurora.org> writes:
> On 10/18/2016 10:07 AM, Punit Agrawal wrote:
>> Although ghes_proc tests for error while reading the error status, it
>> always return success (0). Fix this by propagating the return value.
>>
>> Fixes: d334a49113a4a33 ("ACPI, APEI, Generic Hardware Error Source memory error support")
>> Signed-of-by: Punit Agrawal <punit.agrawa.@arm.com>
>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>> Cc: Len Brown <lenb@kernel.org>
> Tested-by: Tyler Baicar <tbaicar@codeaurora.org>
Thanks for taking the patch for a spin.
Hopefully Rafael can pick the patch as a fixes for the next rc.
>
> Thanks,
> Tyler
>> ---
>> drivers/acpi/apei/ghes.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
>> index f0a029e..0d099a2 100644
>> --- a/drivers/acpi/apei/ghes.c
>> +++ b/drivers/acpi/apei/ghes.c
>> @@ -662,7 +662,7 @@ static int ghes_proc(struct ghes *ghes)
>> ghes_do_proc(ghes, ghes->estatus);
>> out:
>> ghes_clear_estatus(ghes);
>> - return 0;
>> + return rc;
>> }
>> static void ghes_add_timer(struct ghes *ghes)
next prev parent reply other threads:[~2016-10-21 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 16:07 [PATCH] acpi/apei: Fix in-correct return value Punit Agrawal
2016-10-20 19:51 ` Baicar, Tyler
2016-10-21 14:58 ` Punit Agrawal [this message]
2016-10-21 21:28 ` Rafael J. Wysocki
2016-10-22 16:37 ` Borislav Petkov
2016-10-23 0:09 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f9121h4.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=bp@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tbaicar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox