[patch 8/8] acpi-cpufreq: remove dead code

[patch 8/8] acpi-cpufreq: remove dead code

[akpm]

From: Andrew Morton <akpm@osdl.org>

arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:396: warning: 'sw_any_bug_dmi_table' defined but not used

Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c |    2 ++
 1 files changed, 2 insertions(+)

diff -puN arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c~acpi-cpufreq-remove-dead-code arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c~acpi-cpufreq-remove-dead-code
+++ a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
@@ -402,6 +402,7 @@ static int sw_any_bug_found(struct dmi_s
 	return 0;
 }
 
+#ifdef CONFIG_SMP
 static struct dmi_system_id sw_any_bug_dmi_table[] = {
 	{
 		.callback = sw_any_bug_found,
@@ -414,6 +415,7 @@ static struct dmi_system_id sw_any_bug_d
 	},
 	{ }
 };
+#endif
 
 static int
 acpi_cpufreq_cpu_init (
_

Re: [patch 8/8] acpi-cpufreq: remove dead code

[Len Brown]

I would expect to see this same change in both speedstep-centrino.c and acpi-cpufreq.c, no?

On Friday 20 October 2006 17:30, akpm@osdl.org wrote:
> From: Andrew Morton <akpm@osdl.org>
> 
> arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:396: warning: 'sw_any_bug_dmi_table' defined but not used
> 
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c |    2 ++
>  1 files changed, 2 insertions(+)
> 
> diff -puN arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c~acpi-cpufreq-remove-dead-code arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c~acpi-cpufreq-remove-dead-code
> +++ a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> @@ -402,6 +402,7 @@ static int sw_any_bug_found(struct dmi_s
>  	return 0;
>  }
>  
> +#ifdef CONFIG_SMP
>  static struct dmi_system_id sw_any_bug_dmi_table[] = {
>  	{
>  		.callback = sw_any_bug_found,
> @@ -414,6 +415,7 @@ static struct dmi_system_id sw_any_bug_d
>  	},
>  	{ }
>  };
> +#endif
>  
>  static int
>  acpi_cpufreq_cpu_init (
> _
> 

Re: [patch 8/8] acpi-cpufreq: remove dead code

[Dave Jones]

On Sat, Oct 21, 2006 at 01:28:06AM -0400, Len Brown wrote:
 > I would expect to see this same change in both speedstep-centrino.c and acpi-cpufreq.c, no?

Indeed, especially as longterm acpi-cpufreq is going to be the
more interesting of the two.

I'll merge this patch up though, and make the acpi-cpufreq change myself.

Thanks,

	Dave
 
-- 
http://www.codemonkey.org.uk