* Re: [PATCH] ACPI: Fix CMOS RTC Operation Region handler accesses to wrong address of value [not found] <1409814819-30594-1-git-send-email-jlee@suse.com> @ 2014-09-04 19:46 ` Rafael J. Wysocki 2014-09-05 2:06 ` joeyli 0 siblings, 1 reply; 2+ messages in thread From: Rafael J. Wysocki @ 2014-09-04 19:46 UTC (permalink / raw) To: Lee, Chun-Yi Cc: Len Brown, linux-acpi, Lan Tianyu, Lee, Chun-Yi, Rafael J. Wysocki On Thursday, September 04, 2014 03:13:39 PM Lee, Chun-Yi wrote: > The value64 parameter is an u64 point that used to transfer the value > for write to CMOS, or used to return the value that's read from CMOS. > > The value64 is an u64 point, so don't need get address again. It causes > acpi_cmos_rtc_space_handler always return 0 to reader and didn't write > expected value to CMOS. Do we need this fix to go to -stable? > Cc: Lan Tianyu <tianyu.lan@intel.com> > Cc: Len Brown <lenb@kernel.org> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > --- > drivers/acpi/acpi_cmos_rtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c > index 2da8660..81dc750 100644 > --- a/drivers/acpi/acpi_cmos_rtc.c > +++ b/drivers/acpi/acpi_cmos_rtc.c > @@ -33,7 +33,7 @@ acpi_cmos_rtc_space_handler(u32 function, acpi_physical_address address, > void *handler_context, void *region_context) > { > int i; > - u8 *value = (u8 *)&value64; > + u8 *value = (u8 *)value64; > > if (address > 0xff || !value64) > return AE_BAD_PARAMETER; > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: Fix CMOS RTC Operation Region handler accesses to wrong address of value 2014-09-04 19:46 ` [PATCH] ACPI: Fix CMOS RTC Operation Region handler accesses to wrong address of value Rafael J. Wysocki @ 2014-09-05 2:06 ` joeyli 0 siblings, 0 replies; 2+ messages in thread From: joeyli @ 2014-09-05 2:06 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Lee, Chun-Yi, Len Brown, linux-acpi, Lan Tianyu, Rafael J. Wysocki Hi, On Thu, Sep 04, 2014 at 09:46:30PM +0200, Rafael J. Wysocki wrote: > On Thursday, September 04, 2014 03:13:39 PM Lee, Chun-Yi wrote: > > The value64 parameter is an u64 point that used to transfer the value > > for write to CMOS, or used to return the value that's read from CMOS. > > > > The value64 is an u64 point, so don't need get address again. It causes > > acpi_cmos_rtc_space_handler always return 0 to reader and didn't write > > expected value to CMOS. > > Do we need this fix to go to -stable? > Yes, this handler was added since v3.11 kernel. So, need go to -stable. > > Cc: Lan Tianyu <tianyu.lan@intel.com> > > Cc: Len Brown <lenb@kernel.org> > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > > --- > > drivers/acpi/acpi_cmos_rtc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpi_cmos_rtc.c b/drivers/acpi/acpi_cmos_rtc.c > > index 2da8660..81dc750 100644 > > --- a/drivers/acpi/acpi_cmos_rtc.c > > +++ b/drivers/acpi/acpi_cmos_rtc.c > > @@ -33,7 +33,7 @@ acpi_cmos_rtc_space_handler(u32 function, acpi_physical_address address, > > void *handler_context, void *region_context) > > { > > int i; > > - u8 *value = (u8 *)&value64; > > + u8 *value = (u8 *)value64; > > > > if (address > 0xff || !value64) > > return AE_BAD_PARAMETER; > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. Regards Joey Lee ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-05 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1409814819-30594-1-git-send-email-jlee@suse.com>
2014-09-04 19:46 ` [PATCH] ACPI: Fix CMOS RTC Operation Region handler accesses to wrong address of value Rafael J. Wysocki
2014-09-05 2:06 ` joeyli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox