* [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members
@ 2023-09-04 10:40 Andy Shevchenko
2023-09-04 10:50 ` Heikki Krogerus
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-09-04 10:40 UTC (permalink / raw)
To: Saravana Kannan, linux-acpi, linux-kernel
Cc: Andy Shevchenko, Daniel Scally, Heikki Krogerus, Sakari Ailus,
Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman,
Bartosz Golaszewski
Most of the struct fwnode_handle members are for exclusive use with
device links framework. Clarify this by adding a respective comment.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/fwnode.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 5700451b300f..2a72f55d26eb 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -41,6 +41,8 @@ struct device;
struct fwnode_handle {
struct fwnode_handle *secondary;
const struct fwnode_operations *ops;
+
+ /* The below is used solely by device links, don't use otherwise */
struct device *dev;
struct list_head suppliers;
struct list_head consumers;
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members
2023-09-04 10:40 [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members Andy Shevchenko
@ 2023-09-04 10:50 ` Heikki Krogerus
2023-09-04 11:02 ` Sakari Ailus
2023-09-18 16:59 ` Andy Shevchenko
2 siblings, 0 replies; 5+ messages in thread
From: Heikki Krogerus @ 2023-09-04 10:50 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Saravana Kannan, linux-acpi, linux-kernel, Daniel Scally,
Sakari Ailus, Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman,
Bartosz Golaszewski
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> Most of the struct fwnode_handle members are for exclusive use with
> device links framework. Clarify this by adding a respective comment.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Yes, this is important clarification.
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> include/linux/fwnode.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 5700451b300f..2a72f55d26eb 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -41,6 +41,8 @@ struct device;
> struct fwnode_handle {
> struct fwnode_handle *secondary;
> const struct fwnode_operations *ops;
> +
> + /* The below is used solely by device links, don't use otherwise */
> struct device *dev;
> struct list_head suppliers;
> struct list_head consumers;
> --
> 2.40.0.1.gaa8946217a0b
--
heikki
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members
2023-09-04 10:40 [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members Andy Shevchenko
2023-09-04 10:50 ` Heikki Krogerus
@ 2023-09-04 11:02 ` Sakari Ailus
2023-09-18 16:59 ` Andy Shevchenko
2 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2023-09-04 11:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Saravana Kannan, linux-acpi, linux-kernel, Daniel Scally,
Heikki Krogerus, Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman,
Bartosz Golaszewski
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> Most of the struct fwnode_handle members are for exclusive use with
> device links framework. Clarify this by adding a respective comment.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members
2023-09-04 10:40 [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members Andy Shevchenko
2023-09-04 10:50 ` Heikki Krogerus
2023-09-04 11:02 ` Sakari Ailus
@ 2023-09-18 16:59 ` Andy Shevchenko
2023-09-19 7:21 ` Greg Kroah-Hartman
2 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-09-18 16:59 UTC (permalink / raw)
To: Saravana Kannan, linux-acpi, linux-kernel
Cc: Daniel Scally, Heikki Krogerus, Sakari Ailus, Rafael J. Wysocki,
Len Brown, Greg Kroah-Hartman, Bartosz Golaszewski
On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> Most of the struct fwnode_handle members are for exclusive use with
> device links framework. Clarify this by adding a respective comment.
Thank you, folks, for the review. Rafael, Greg, who can apply this?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members
2023-09-18 16:59 ` Andy Shevchenko
@ 2023-09-19 7:21 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2023-09-19 7:21 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Saravana Kannan, linux-acpi, linux-kernel, Daniel Scally,
Heikki Krogerus, Sakari Ailus, Rafael J. Wysocki, Len Brown,
Bartosz Golaszewski
On Mon, Sep 18, 2023 at 07:59:55PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 04, 2023 at 01:40:46PM +0300, Andy Shevchenko wrote:
> > Most of the struct fwnode_handle members are for exclusive use with
> > device links framework. Clarify this by adding a respective comment.
>
> Thank you, folks, for the review. Rafael, Greg, who can apply this?
I will, give me some time to catch up with my pending patch queue.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-19 7:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-04 10:40 [PATCH v1 1/1] device property: Clarify usage scope of some struct fwnode_handle members Andy Shevchenko
2023-09-04 10:50 ` Heikki Krogerus
2023-09-04 11:02 ` Sakari Ailus
2023-09-18 16:59 ` Andy Shevchenko
2023-09-19 7:21 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox