From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Paul Bolle <pebolle@tiscali.nl>, Lv Zheng <lv.zheng@intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"
Date: Tue, 26 Mar 2013 14:34:25 +0100 [thread overview]
Message-ID: <3588021.V98D5VToQr@vostro.rjw.lan> (raw)
In-Reply-To: <1363689661.1390.9.camel@x61.thuisdomein>
On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote:
> Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> removed from that header in v3.8, with commit
> 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> acmacros.h divergences."). That commit did not explain why that macro
> was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed
> too, as it is unused.
Lv, can you please comment here?
Rafael
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Eyeball tested.
>
> drivers/acpi/Kconfig | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 92ed969..006b714 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -298,14 +298,6 @@ config ACPI_DEBUG
> Documentation/kernel-parameters.txt to control the type and
> amount of debug output.
>
> -config ACPI_DEBUG_FUNC_TRACE
> - bool "Additionally enable ACPI function tracing"
> - default n
> - depends on ACPI_DEBUG
> - help
> - ACPI Debug Statements slow down ACPI processing. Function trace
> - is about half of the penalty and is rarely useful.
> -
> config ACPI_PCI_SLOT
> bool "PCI slot detection driver"
> depends on SYSFS
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-03-26 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 10:41 [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE" Paul Bolle
2013-03-26 13:34 ` Rafael J. Wysocki [this message]
2013-04-04 21:00 ` Rafael J. Wysocki
2013-04-07 1:02 ` Zheng, Lv
2013-04-07 7:00 ` Zheng, Lv
2013-04-07 8:48 ` Rafael J. Wysocki
2013-04-07 7:07 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3588021.V98D5VToQr@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox