Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday, March 26, 2013 02:34:25 PM Rafael J. Wysocki wrote:
> On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote:
> > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> > removed from that header in v3.8, with commit
> > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > acmacros.h divergences."). That commit did not explain why that macro
> > was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed
> > too, as it is unused.
> 
> Lv, can you please comment here?

Lv, I'm still waiting for your comment regarding the commit mentioned above.

Thanks,
Rafael


> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Eyeball tested.
> > 
> >  drivers/acpi/Kconfig | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> > index 92ed969..006b714 100644
> > --- a/drivers/acpi/Kconfig
> > +++ b/drivers/acpi/Kconfig
> > @@ -298,14 +298,6 @@ config ACPI_DEBUG
> >  	  Documentation/kernel-parameters.txt to control the type and
> >  	  amount of debug output.
> >  
> > -config ACPI_DEBUG_FUNC_TRACE
> > -	bool "Additionally enable ACPI function tracing"
> > -	default n
> > -	depends on ACPI_DEBUG
> > -	help
> > -	  ACPI Debug Statements slow down ACPI processing. Function trace
> > -	  is about half of the penalty and is rarely useful.
> > -
> >  config ACPI_PCI_SLOT
> >  	bool "PCI slot detection driver"
> >  	depends on SYSFS
> > 
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.