* [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message
@ 2025-09-02 11:45 Colin Ian King
2025-09-02 15:54 ` Ira Weiny
2025-09-04 15:26 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Colin Ian King @ 2025-09-02 11:45 UTC (permalink / raw)
To: Dan Williams, Vishal Verma, Dave Jiang, Ira Weiny,
Rafael J . Wysocki, Len Brown, Jia He, nvdimm, linux-acpi
Cc: kernel-janitors, linux-kernel
There appears to be a cut-n-paste error with the incorrect field
ndr_desc->numa_node being reported for the target node. Fix this by
using ndr_desc->target_node instead.
Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/acpi/nfit/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index ae035b93da08..3eb56b77cb6d 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
if (ndr_desc->target_node == NUMA_NO_NODE) {
ndr_desc->target_node = phys_to_target_node(spa->address);
dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
- NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
+ NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
}
/*
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message
2025-09-02 11:45 [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message Colin Ian King
@ 2025-09-02 15:54 ` Ira Weiny
2025-09-04 15:26 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Ira Weiny @ 2025-09-02 15:54 UTC (permalink / raw)
To: Colin Ian King, Dan Williams, Vishal Verma, Dave Jiang, Ira Weiny,
Rafael J . Wysocki, Len Brown, Jia He, nvdimm, linux-acpi
Cc: kernel-janitors, linux-kernel
Colin Ian King wrote:
> There appears to be a cut-n-paste error with the incorrect field
NIT: 'There __is__ a cut-n-paste error..." ;-)
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
>
> Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index ae035b93da08..3eb56b77cb6d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> if (ndr_desc->target_node == NUMA_NO_NODE) {
> ndr_desc->target_node = phys_to_target_node(spa->address);
> dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> - NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> + NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> }
>
> /*
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message
2025-09-02 11:45 [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message Colin Ian King
2025-09-02 15:54 ` Ira Weiny
@ 2025-09-04 15:26 ` Rafael J. Wysocki
2025-09-04 16:06 ` Ira Weiny
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2025-09-04 15:26 UTC (permalink / raw)
To: Colin Ian King, Dan Williams, Dave Jiang
Cc: Vishal Verma, Ira Weiny, Len Brown, Jia He, nvdimm, linux-acpi,
kernel-janitors, linux-kernel
On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There appears to be a cut-n-paste error with the incorrect field
> ndr_desc->numa_node being reported for the target node. Fix this by
> using ndr_desc->target_node instead.
>
> Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/acpi/nfit/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index ae035b93da08..3eb56b77cb6d 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> if (ndr_desc->target_node == NUMA_NO_NODE) {
> ndr_desc->target_node = phys_to_target_node(spa->address);
> dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> - NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> + NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> }
>
> /*
> --
Dan, Dave, are you guys going to take this one, or should I take care of it?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message
2025-09-04 15:26 ` Rafael J. Wysocki
@ 2025-09-04 16:06 ` Ira Weiny
0 siblings, 0 replies; 4+ messages in thread
From: Ira Weiny @ 2025-09-04 16:06 UTC (permalink / raw)
To: Rafael J. Wysocki, Colin Ian King, Dan Williams, Dave Jiang
Cc: Vishal Verma, Ira Weiny, Len Brown, Jia He, nvdimm, linux-acpi,
kernel-janitors, linux-kernel
Rafael J. Wysocki wrote:
> On Tue, Sep 2, 2025 at 1:46 PM Colin Ian King <colin.i.king@gmail.com> wrote:
> >
> > There appears to be a cut-n-paste error with the incorrect field
> > ndr_desc->numa_node being reported for the target node. Fix this by
> > using ndr_desc->target_node instead.
> >
> > Fixes: f060db99374e ("ACPI: NFIT: Use fallback node id when numa info in NFIT table is incorrect")
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > drivers/acpi/nfit/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> > index ae035b93da08..3eb56b77cb6d 100644
> > --- a/drivers/acpi/nfit/core.c
> > +++ b/drivers/acpi/nfit/core.c
> > @@ -2637,7 +2637,7 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
> > if (ndr_desc->target_node == NUMA_NO_NODE) {
> > ndr_desc->target_node = phys_to_target_node(spa->address);
> > dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
> > - NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
> > + NUMA_NO_NODE, ndr_desc->target_node, &res.start, &res.end);
> > }
> >
> > /*
> > --
>
> Dan, Dave, are you guys going to take this one, or should I take care of it?
Apologies, I should have said I'm taking this one. It is queued up.
Thanks for the ping,
Ira
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-04 16:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-02 11:45 [PATCH][next] ACPI: NFIT: Fix incorrect ndr_desc being reportedin dev_err message Colin Ian King
2025-09-02 15:54 ` Ira Weiny
2025-09-04 15:26 ` Rafael J. Wysocki
2025-09-04 16:06 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox