* [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
[not found] <20190404104222.23900-1-yuehaibing@huawei.com>
@ 2019-04-04 14:17 ` Yue Haibing
2019-04-04 14:44 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yue Haibing @ 2019-04-04 14:17 UTC (permalink / raw)
To: myungjoo.ham, cw00.choi, wens, hdegoede, rjw
Cc: linux-kernel, linux-acpi, YueHaibing
From: YueHaibing <yuehaibing@huawei.com>
As Hans de Goede pointed, using this driver without ACPI
makes little sense, so add ACPI dependency to Kconfig entry
to fix a build error while CONFIG_ACPI is not set.
drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
put_device(&adev->dev);
Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
Reported-by: Hulk Robot <hulkci@huawei.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: rework patch
---
drivers/extcon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 1ed4b45..de06faf 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -30,7 +30,7 @@ config EXTCON_ARIZONA
config EXTCON_AXP288
tristate "X-Power AXP288 EXTCON support"
- depends on MFD_AXP20X && USB_SUPPORT && X86
+ depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
select USB_ROLE_SWITCH
help
Say Y here to enable support for USB peripheral detection
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-04 14:17 ` [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Yue Haibing
@ 2019-04-04 14:44 ` Hans de Goede
2019-04-05 5:36 ` Mukesh Ojha
2019-04-11 23:30 ` Chanwoo Choi
2 siblings, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2019-04-04 14:44 UTC (permalink / raw)
To: Yue Haibing, myungjoo.ham, cw00.choi, wens, rjw; +Cc: linux-kernel, linux-acpi
Hi,
On 04-04-19 16:17, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
>
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
> put_device(&adev->dev);
>
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch looks to me, thanks:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> v2: rework patch
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-04 14:17 ` [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Yue Haibing
2019-04-04 14:44 ` Hans de Goede
@ 2019-04-05 5:36 ` Mukesh Ojha
2019-04-05 5:36 ` Mukesh Ojha
2019-04-11 23:30 ` Chanwoo Choi
2 siblings, 1 reply; 8+ messages in thread
From: Mukesh Ojha @ 2019-04-05 5:36 UTC (permalink / raw)
To: Yue Haibing, myungjoo.ham, cw00.choi, wens, hdegoede, rjw
Cc: linux-kernel, linux-acpi
On 4/4/2019 7:47 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
>
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
> put_device(&adev->dev);
>
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This looks good too.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> v2: rework patch
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-05 5:36 ` Mukesh Ojha
@ 2019-04-05 5:36 ` Mukesh Ojha
0 siblings, 0 replies; 8+ messages in thread
From: Mukesh Ojha @ 2019-04-05 5:36 UTC (permalink / raw)
To: Yue Haibing, myungjoo.ham, cw00.choi, wens, hdegoede, rjw
Cc: linux-kernel, linux-acpi
On 4/4/2019 7:47 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
>
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
> put_device(&adev->dev);
>
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This looks good too.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> v2: rework patch
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-04 14:17 ` [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Yue Haibing
2019-04-04 14:44 ` Hans de Goede
2019-04-05 5:36 ` Mukesh Ojha
@ 2019-04-11 23:30 ` Chanwoo Choi
2019-04-11 23:30 ` Chanwoo Choi
2019-04-12 0:59 ` Chanwoo Choi
2 siblings, 2 replies; 8+ messages in thread
From: Chanwoo Choi @ 2019-04-11 23:30 UTC (permalink / raw)
To: Yue Haibing, myungjoo.ham, wens, hdegoede, rjw; +Cc: linux-kernel, linux-acpi
On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
>
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
> put_device(&adev->dev);
>
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: rework patch
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-11 23:30 ` Chanwoo Choi
@ 2019-04-11 23:30 ` Chanwoo Choi
2019-04-12 0:59 ` Chanwoo Choi
1 sibling, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2019-04-11 23:30 UTC (permalink / raw)
To: Yue Haibing, myungjoo.ham, wens, hdegoede, rjw; +Cc: linux-kernel, linux-acpi
On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> As Hans de Goede pointed, using this driver without ACPI
> makes little sense, so add ACPI dependency to Kconfig entry
> to fix a build error while CONFIG_ACPI is not set.
>
> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
> put_device(&adev->dev);
>
> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: rework patch
> ---
> drivers/extcon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1ed4b45..de06faf 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-11 23:30 ` Chanwoo Choi
2019-04-11 23:30 ` Chanwoo Choi
@ 2019-04-12 0:59 ` Chanwoo Choi
2019-04-12 0:59 ` Chanwoo Choi
1 sibling, 1 reply; 8+ messages in thread
From: Chanwoo Choi @ 2019-04-12 0:59 UTC (permalink / raw)
To: myungjoo.ham, wens, hdegoede, rjw, stable@vger.kernel.org
Cc: linux-kernel, linux-acpi
Dear all,
+ stable@vger.kernel.org
It should be posted to stable@vger.kernel.org
in order to merge it to stable tree.
Regards,
Chanwoo Choi
On 19. 4. 12. 오전 8:30, Chanwoo Choi wrote:
> On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> As Hans de Goede pointed, using this driver without ACPI
>> makes little sense, so add ACPI dependency to Kconfig entry
>> to fix a build error while CONFIG_ACPI is not set.
>>
>> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
>> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
>> put_device(&adev->dev);
>>
>> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Suggested-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: rework patch
>> ---
>> drivers/extcon/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index 1ed4b45..de06faf 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>>
>> config EXTCON_AXP288
>> tristate "X-Power AXP288 EXTCON support"
>> - depends on MFD_AXP20X && USB_SUPPORT && X86
>> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
>> select USB_ROLE_SWITCH
>> help
>> Say Y here to enable support for USB peripheral detection
>>
>
> Applied it. Thanks.
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry
2019-04-12 0:59 ` Chanwoo Choi
@ 2019-04-12 0:59 ` Chanwoo Choi
0 siblings, 0 replies; 8+ messages in thread
From: Chanwoo Choi @ 2019-04-12 0:59 UTC (permalink / raw)
To: myungjoo.ham, wens, hdegoede, rjw, stable@vger.kernel.org
Cc: linux-kernel, linux-acpi
Dear all,
+ stable@vger.kernel.org
It should be posted to stable@vger.kernel.org
in order to merge it to stable tree.
Regards,
Chanwoo Choi
On 19. 4. 12. 오전 8:30, Chanwoo Choi wrote:
> On 19. 4. 4. 오후 11:17, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> As Hans de Goede pointed, using this driver without ACPI
>> makes little sense, so add ACPI dependency to Kconfig entry
>> to fix a build error while CONFIG_ACPI is not set.
>>
>> drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe':
>> drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type
>> put_device(&adev->dev);
>>
>> Fixes: 0cf064db948a ("extcon: axp288: Convert to use acpi_dev_get_first_match_dev()")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Suggested-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: rework patch
>> ---
>> drivers/extcon/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>> index 1ed4b45..de06faf 100644
>> --- a/drivers/extcon/Kconfig
>> +++ b/drivers/extcon/Kconfig
>> @@ -30,7 +30,7 @@ config EXTCON_ARIZONA
>>
>> config EXTCON_AXP288
>> tristate "X-Power AXP288 EXTCON support"
>> - depends on MFD_AXP20X && USB_SUPPORT && X86
>> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
>> select USB_ROLE_SWITCH
>> help
>> Say Y here to enable support for USB peripheral detection
>>
>
> Applied it. Thanks.
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-12 0:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190404104222.23900-1-yuehaibing@huawei.com>
2019-04-04 14:17 ` [PATCH v2] extcon: axp288: Add a depends on ACPI to the Kconfig entry Yue Haibing
2019-04-04 14:44 ` Hans de Goede
2019-04-05 5:36 ` Mukesh Ojha
2019-04-05 5:36 ` Mukesh Ojha
2019-04-11 23:30 ` Chanwoo Choi
2019-04-11 23:30 ` Chanwoo Choi
2019-04-12 0:59 ` Chanwoo Choi
2019-04-12 0:59 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox