From: Borislav Petkov <bp@alien8.de>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
Toshi Kani <toshi.kani@hpe.com>
Subject: Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register
Date: Mon, 8 Aug 2022 20:37:42 +0200 [thread overview]
Message-ID: <YvFX9vTilqMpsF9u@zn.tnic> (raw)
In-Reply-To: <CAJZ5v0gUbKYaxRcZsYO6eq7vLgKdgfdLdoL_Hzmd6r-JczkVPg@mail.gmail.com>
+ Toshi.
On Mon, Aug 08, 2022 at 08:17:58PM +0200, Rafael J. Wysocki wrote:
> This effectively makes EDAC depend on GHES which may not be always
> valid AFAICS.
Yes, and this has been getting on my nerves since forever.
The GHES code which does collect all those errors *forces* the
registration of an EDAC module which does only the reporting.
Which cannot be any more backwards.
What should happen is, GHES inits and starts working on the errors.
Then, at some point later, ghes_edac loads and starts reporting whatever
it gets. If there's no EDAC module, it doesn't report them. The same way
MCA works.
That's it.
And then ghes_edac can be made a normal module again and we can get rid
of this insanity.
Jia, willing to try it?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-08 18:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:32 [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register Jia He
2022-08-08 18:17 ` Rafael J. Wysocki
2022-08-08 18:37 ` Borislav Petkov [this message]
2022-08-08 20:40 ` Kani, Toshi
2022-08-08 20:57 ` Borislav Petkov
2022-08-08 21:11 ` Kani, Toshi
2022-08-08 21:20 ` Borislav Petkov
2022-08-08 21:36 ` Kani, Toshi
2022-08-09 7:40 ` Borislav Petkov
2022-08-09 9:24 ` 回复: " Justin He
2022-08-09 11:15 ` Borislav Petkov
2022-08-09 14:36 ` Kani, Toshi
2022-08-09 15:14 ` Borislav Petkov
2022-08-09 15:39 ` Kani, Toshi
2022-08-09 17:11 ` Borislav Petkov
2022-08-09 17:36 ` Kani, Toshi
2022-08-09 16:51 ` Justin He
2022-08-09 17:15 ` Borislav Petkov
2022-08-09 18:46 ` Borislav Petkov
2022-08-10 6:00 ` Justin He
2022-08-10 8:28 ` Borislav Petkov
2022-08-10 8:53 ` Justin He
2022-08-11 0:39 ` Justin He
2022-08-11 7:40 ` Borislav Petkov
2022-08-09 10:06 ` Justin He
2022-08-09 14:57 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvFX9vTilqMpsF9u@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=justin.he@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox