From: Borislav Petkov <bp@alien8.de>
To: Justin He <Justin.He@arm.com>
Cc: "Kani, Toshi" <toshi.kani@hpe.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <James.Morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>,
nd <nd@arm.com>
Subject: Re: 回复: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register
Date: Thu, 11 Aug 2022 09:40:32 +0200 [thread overview]
Message-ID: <YvSycPr+co+G5j+K@zn.tnic> (raw)
In-Reply-To: <DBBPR08MB4538CB7A96F4C8CA42C29243F7649@DBBPR08MB4538.eurprd08.prod.outlook.com>
On Thu, Aug 11, 2022 at 12:39:10AM +0000, Justin He wrote:
> > +static int __init ghes_edac_init(void)
> > +{
> > + struct ghes *g, *g_tmp;
> > +
> > + ghes_devs = ghes_get_devices(force_load);
> > + if (ghes_devs)
> Should it be changed to if(!ghes_devs) ?
> Otherwise, this ghes_edac_init() on Arm will always return with ENODEV
> because ! ghes_get_devices().
Yes, of course, sorry about that.
I mean, for a lack of a better idea, it returns a list of devices... ;-\
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-11 7:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:32 [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register Jia He
2022-08-08 18:17 ` Rafael J. Wysocki
2022-08-08 18:37 ` Borislav Petkov
2022-08-08 20:40 ` Kani, Toshi
2022-08-08 20:57 ` Borislav Petkov
2022-08-08 21:11 ` Kani, Toshi
2022-08-08 21:20 ` Borislav Petkov
2022-08-08 21:36 ` Kani, Toshi
2022-08-09 7:40 ` Borislav Petkov
2022-08-09 9:24 ` 回复: " Justin He
2022-08-09 11:15 ` Borislav Petkov
2022-08-09 14:36 ` Kani, Toshi
2022-08-09 15:14 ` Borislav Petkov
2022-08-09 15:39 ` Kani, Toshi
2022-08-09 17:11 ` Borislav Petkov
2022-08-09 17:36 ` Kani, Toshi
2022-08-09 16:51 ` Justin He
2022-08-09 17:15 ` Borislav Petkov
2022-08-09 18:46 ` Borislav Petkov
2022-08-10 6:00 ` Justin He
2022-08-10 8:28 ` Borislav Petkov
2022-08-10 8:53 ` Justin He
2022-08-11 0:39 ` Justin He
2022-08-11 7:40 ` Borislav Petkov [this message]
2022-08-09 10:06 ` Justin He
2022-08-09 14:57 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvSycPr+co+G5j+K@zn.tnic \
--to=bp@alien8.de \
--cc=James.Morse@arm.com \
--cc=Justin.He@arm.com \
--cc=jarkko@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nd@arm.com \
--cc=rafael@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox