From: Borislav Petkov <bp@alien8.de>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Jia He <justin.he@arm.com>, Len Brown <lenb@kernel.org>,
James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:EDAC-CORE" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register
Date: Tue, 9 Aug 2022 09:40:47 +0200 [thread overview]
Message-ID: <YvIPf/m3hU46S9Ik@zn.tnic> (raw)
In-Reply-To: <PH7PR84MB1838BF4F8B56EF1E24FCF1DC82639@PH7PR84MB1838.NAMPRD84.PROD.OUTLOOK.COM>
On Mon, Aug 08, 2022 at 09:36:13PM +0000, Kani, Toshi wrote:
> Platforms with ACPI GHES support should use ghes_edac. This is the
> case on Arm. The x86 side has additional platform ID check to protect
> from legacy buggy GHES FW existed before ghes_edac enablement.
Sounds to me like we should put all that logic in ghes.c and out of
ghes_edac and the EDAC drivers will query it by doing upon load:
<edac_driver>_init:
if (ghes_edac_driver_is_preferred())
return -ENODEV;
And then ghes_edac can become a normal driver module again.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-08-09 7:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:32 [PATCH] ACPI: APEI: move edac_init ahead of ghes platform drv register Jia He
2022-08-08 18:17 ` Rafael J. Wysocki
2022-08-08 18:37 ` Borislav Petkov
2022-08-08 20:40 ` Kani, Toshi
2022-08-08 20:57 ` Borislav Petkov
2022-08-08 21:11 ` Kani, Toshi
2022-08-08 21:20 ` Borislav Petkov
2022-08-08 21:36 ` Kani, Toshi
2022-08-09 7:40 ` Borislav Petkov [this message]
2022-08-09 9:24 ` 回复: " Justin He
2022-08-09 11:15 ` Borislav Petkov
2022-08-09 14:36 ` Kani, Toshi
2022-08-09 15:14 ` Borislav Petkov
2022-08-09 15:39 ` Kani, Toshi
2022-08-09 17:11 ` Borislav Petkov
2022-08-09 17:36 ` Kani, Toshi
2022-08-09 16:51 ` Justin He
2022-08-09 17:15 ` Borislav Petkov
2022-08-09 18:46 ` Borislav Petkov
2022-08-10 6:00 ` Justin He
2022-08-10 8:28 ` Borislav Petkov
2022-08-10 8:53 ` Justin He
2022-08-11 0:39 ` Justin He
2022-08-11 7:40 ` Borislav Petkov
2022-08-09 10:06 ` Justin He
2022-08-09 14:57 ` Kani, Toshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvIPf/m3hU46S9Ik@zn.tnic \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=justin.he@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rafael@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox