[PATCH v2] ACPI: Clarify resource conflict message

[PATCH v2] ACPI: Clarify resource conflict message

[Jean Delvare]

From: Jean Delvare <jdelvare@suse.de>
Subject: ACPI: Clarify resource conflict message

The message "ACPI: Device needs an ACPI driver" is misleading. The
device _may_ need an ACPI driver, if the BIOS implemented a custom
API for the device in question (which, AFAIK, can't be checked.) If
not, then either a generic ACPI driver may be used (for example
"thermal"), or nothing can be done (other than a white list).

I propose to reword the message to:

ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver

which I think is more correct. Comments and suggestions welcome.

I also added a message warning about possible problems and system
instability when users pass acpi_enforce_resources=lax, as suggested
by Len.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Len Brown <len.brown@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>
---
Len, if you are satisfied with the wording, any chance to have this
patch in 2.6.31? Thanks.

 drivers/acpi/osl.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--- linux-2.6.31-rc9.orig/drivers/acpi/osl.c	2009-09-08 09:46:51.000000000 +0200
+++ linux-2.6.31-rc9/drivers/acpi/osl.c	2009-09-08 13:56:53.000000000 +0200
@@ -1182,7 +1182,13 @@ int acpi_check_resource_conflict(struct
 			       res_list_elem->name,
 			       (long long) res_list_elem->start,
 			       (long long) res_list_elem->end);
-			printk(KERN_INFO "ACPI: Device needs an ACPI driver\n");
+			if (acpi_enforce_resources == ENFORCE_RESOURCES_LAX)
+				printk(KERN_NOTICE "ACPI: This conflict may"
+				       " cause random problems and system"
+				       " instability\n");
+			printk(KERN_INFO "ACPI: If an ACPI driver is available"
+			       " for this device, you should use it instead of"
+			       " the native driver\n");
 		}
 		if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT)
 			return -EBUSY;

-- 
Jean Delvare
Suse L3

Re: [PATCH v2] ACPI: Clarify resource conflict message

[Jean Delvare]

Len, Rui, can you please push this patch upstream quickly? We get
more and more reports about this, and an improved wording would
definitely help.

Thanks.

Le mardi 08 septembre 2009, Jean Delvare a écrit :
> From: Jean Delvare <jdelvare@suse.de>
> Subject: ACPI: Clarify resource conflict message
> 
> The message "ACPI: Device needs an ACPI driver" is misleading. The
> device _may_ need an ACPI driver, if the BIOS implemented a custom
> API for the device in question (which, AFAIK, can't be checked.) If
> not, then either a generic ACPI driver may be used (for example
> "thermal"), or nothing can be done (other than a white list).
> 
> I propose to reword the message to:
> 
> ACPI: If an ACPI driver is available for this device, you should use
> it instead of the native driver
> 
> which I think is more correct. Comments and suggestions welcome.
> 
> I also added a message warning about possible problems and system
> instability when users pass acpi_enforce_resources=lax, as suggested
> by Len.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>
> ---
> Len, if you are satisfied with the wording, any chance to have this
> patch in 2.6.31? Thanks.
> 
>  drivers/acpi/osl.c |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> --- linux-2.6.31-rc9.orig/drivers/acpi/osl.c	2009-09-08 09:46:51.000000000 +0200
> +++ linux-2.6.31-rc9/drivers/acpi/osl.c	2009-09-08 13:56:53.000000000 +0200
> @@ -1182,7 +1182,13 @@ int acpi_check_resource_conflict(struct
>  			       res_list_elem->name,
>  			       (long long) res_list_elem->start,
>  			       (long long) res_list_elem->end);
> -			printk(KERN_INFO "ACPI: Device needs an ACPI driver\n");
> +			if (acpi_enforce_resources == ENFORCE_RESOURCES_LAX)
> +				printk(KERN_NOTICE "ACPI: This conflict may"
> +				       " cause random problems and system"
> +				       " instability\n");
> +			printk(KERN_INFO "ACPI: If an ACPI driver is available"
> +			       " for this device, you should use it instead of"
> +			       " the native driver\n");
>  		}
>  		if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT)
>  			return -EBUSY;
> 



-- 
Jean Delvare
Suse L3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ACPI: Clarify resource conflict message

[Len Brown]

applied

thanks,
Len Brown, Intel Open Source Technology Center