From: Len Brown <lenb@kernel.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: akpm@linux-foundation.org, linux-acpi@vger.kernel.org,
arekm@maven.pl, feng.tang@intel.com, flinco@libero.it,
mad_soft@inbox.ru, rjw@sisk.pl
Subject: Re: [patch 7/7] acpi: remove old blacklist entries
Date: Fri, 19 Feb 2010 00:44:30 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.1002190028510.17638@localhost.localdomain> (raw)
In-Reply-To: <20100217212851.GA27092@srcf.ucam.org>
> So the APM idle loop won't have been used?
APM -- by definition -- is not present on SMP motherboards,
and thus is a non-factor on motherboards where acpi=ht
would be used.
> I was under the impression
> that C1 was preferable to just calling hlt, but I'll admit to having no
> idea if that's true for the PIII.
C1 and HLT are synonymous on P-III, and also many other systems.
MWAIT hints for use in the idle loop were added after Pentium III.
The power savings of MWAIT for C1 is the same as HLT, but
the wakeup mechanism is lower overhead, especially on systems
with lots of processors.
Today, MWAIT extension "hints" are used to get into deep C-states,
but that was not the case for PIII.
> I'd also have expected there to be at
> least S1, so ACPI would be a functional improvement.
Apparently nobody has complained about lacking that feature
on this motherboard during the last 6 years, so I wouldn't
recommend losing any sleep over it.
> > > At least one of them covers a single submodel in a range, despite them
> > > all running the same BIOS. I'd really lean towards them being bogus at
> > > this stage of the game.
> >
> > While I too vote for consistency and less cruft is better,
> > I'd like to keep the acpi_ht issue at hand apart from the
> > inconsistency in old thinkpad BIOS DMI list issue; as they
> > are logically independent.
>
> They're similar in that we have absolutely no idea why these entries are
> present, potentially resulting in us reducing the functionality of
> machines that would otherwise work happily.
I know for a fact that some of the entries on that list are valid.
I'm delited to clean up the ones that are cruft, and I thank you for
noticing that a cleanup is necessary, but deleting them en-masse
would be folly.
thanks,
-Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-02-19 5:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:37 [patch 7/7] acpi: remove old blacklist entries akpm
2010-02-03 23:04 ` Henrique de Moraes Holschuh
2010-02-16 7:53 ` Len Brown
2010-02-16 8:19 ` Len Brown
2010-02-16 15:40 ` Matthew Garrett
2010-02-17 2:49 ` Len Brown
2010-02-17 14:32 ` Matthew Garrett
2010-02-17 18:24 ` Len Brown
2010-02-17 18:31 ` Matthew Garrett
2010-02-17 19:43 ` Henrique de Moraes Holschuh
2010-02-17 21:23 ` Len Brown
2010-02-17 21:28 ` Matthew Garrett
2010-02-19 5:44 ` Len Brown [this message]
2010-02-19 5:53 ` [PATCH 1/2] ACPI: remove "acpi=ht" DMI blacklist Len Brown
2010-02-19 5:55 ` [patch 2/2] ACPI: delete the "acpi=ht" boot option Len Brown
2010-02-23 11:11 ` [patch 7/7] acpi: remove old blacklist entries Thomas Renninger
2010-03-14 20:35 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1002190028510.17638@localhost.localdomain \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arekm@maven.pl \
--cc=feng.tang@intel.com \
--cc=flinco@libero.it \
--cc=linux-acpi@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox